8000 Added pre-0.0.21 color preset by applejag · Pull Request #80 · kubecolor/kubecolor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added pre-0.0.21 color preset #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 15, 2024
Merged

Added pre-0.0.21 color preset #80

merged 3 commits into from
Mar 15, 2024

Conversation

applejag
Copy link
Member
@applejag applejag commented Mar 15, 2024 •
edited
Loading

Description

One of the first issues on this repo was that the color scheme changed (#4).

Preview

image

The coloring is not identical in some areas such as kubectl describe, but it's close enough. Can't get 100% old scheme as a lot of parsing is done differently now.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

What you changed

  • Added color schemes from the pre-0.0.21/hidetatz version

Why you think we should change it

For people coming from hidetatz's kubecolor then this is a big change. This PR adds back that color scheme, in case they really liked it.

Related issue (if exists)

Relates to #4

@applejag applejag added the enhancement New feature or request label Mar 15, 2024
@applejag applejag self-assigned this Mar 15, 2024
@applejag applejag requested a review from prune998 March 15, 2024 20:24
applejag
applejag commented Mar 15, 2024
View reviewed changes
@prune998
Copy link
Contributor

I'm good with the naming so you can merge if you're good too.

@applejag
Copy link
Member Author

I'm good with the naming so you can merge if you're good too.

Alright. But just had another thought. Do we want to name this legacy-0.0.20 instead? Or just v0.0.20?

Is it more important which version the theme changed (pre-0.0.21), or the last version it had the theme (v0.0.20)?

@prune998
Copy link
Contributor

Maybe just setting the version makes sens, so v0.0.20. it's simpler. But it's not something people can compute themselves, they have to pick one based on the documentation.... so the easiest the better.

@applejag
Copy link
Member Author

Alright! 👌 Just to get this right, you mean "let's go with pre-0.0.21", ye?

@prune998
Copy link
Contributor

I mean you can chose :) I'm ok with both...

@applejag applejag merged commit 345ca07 into main Mar 15, 2024
@applejag applejag deleted the feature/pre-0.0.21-preset branch March 15, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prune998 prune998 Awaiting requested review from prune998

Assignees

@applejag applejag

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@applejag @prune998
0