[[FIX]] Limit "Too many Errors" (E043) to errors only #3562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the E043 condition trigger only for errors and not warnings Closes #3444
This updates maxerr doc to reflect that only errors are considered
Update testRawOnError, insideEval in core and restOperatorWithoutIdentifier in parser tests to reflect maxerr no longer counting in warnings.
This modifies testRawOnError to make sure maxerr constrain is applied on errors. This adds testRawOnWarning to make sure maxerr constrain does not count warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #3444 ,
E043is triggered with "Too many Errors" even if there are just warnings in the checked code. This happens because the condition to trigger the saidE043error is:Which clearly checks for the total count of all the messages in
JSHINT.errorsarray, The issue is that, this array not only contains errors but also warnings and informative messages. This makes theE043run even if there are no errors but only warnings exceeding the count defined inmaxerrconfig.This PR will modify the condition for running into
E043, by ignoring all warnings and other messages and considering only errors.This also updates the
maxerrdocumentation to reflect the above change.The tests changed to accommodate for the new behavior are:
core.js:testRawOnError"Too many errors." is no longer being thrown because "Unnecessary semicolon" is a warning (
W032)core.js:insideEvalSimilar case of "Too many errors." not triggering (
maxerris set to 1 here) as "eval can be harmful." is a warning (W061)parser.js:restOperatorWithoutIdentifierWe run into "Too many errors." at
9:22now instead of8:30because the warnings in between are no longer considered.This PR closes #3444