Fix ElementInternals accessibility getters/setters #3865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75d3fdd to
f5d7070
Compare
|
Implementation report: this was relatively easy without AI. Sure, autocomplete could have helped sometimes, and I might have been tempted to get it to implement some of the setters tests. (I'm not sure that would have saved any time though.) But this ended up being a pretty simple issue that I was able to bang out unassisted without problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web platform test coverage for these was woefully incomplete, so when we added them in d6c0ab2 they did not actually work at all.
Closes #3732.