8000 Add support for the latest gleam_stdlib (v0.60.0) by gmartsenkov · Pull Request #21 · jrstrunk/tempo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for the latest gleam_stdlib (v0.60.0) #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025

Conversation

gmartsenkov
Copy link
Contributor
@gmartsenkov gmartsenkov commented May 20, 2025
  • Some of the types have been moved to gleam/dynamic/decode
  • Remove use of the deprecated dynamic#from call
  • Adds unix_epoch constant - to easily use it as a default value in structs without having to make a function call

My text editor decided to remove all trailing whitespace chars - I understand this is a personal thing. Let me know if that's okay and if they're there on purpose.

@jrstrunk
Copy link
Owner

Thank you for the contribution! This looks great. The only thing I would ask is that you make the unix_epoch const internal, then re-export it from the datetime module, that way it can be accessed via datetime.unix_epoch instead of tempo.unix_epoch. Otherwise, that is a great inclusion!

@jrstrunk jrstrunk merged commit 3238c6a into jrstrunk:main May 20, 2025
1 check failed
@jrstrunk
Copy link
Owner

Fantastic, thank you! Looks like the test runner is complaining about formatting, but I will merge anyway. I might push another change in a moment and can fix any formatting then.

@gmartsenkov
Copy link
Contributor Author

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0