8000 Improved reloading by jrsaruo · Pull Request #80 · jrsaruo/MediaViewer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improved reloading #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 29, 2023
Merged

Improved reloading #80

merged 16 commits into from
Nov 29, 2023

Conversation

jrsaruo
Copy link
Owner
@jrsaruo jrsaruo commented Nov 29, 2023

Changes

  • Changed AnyMediaIdentifier.init(rawValue:) to AnyMediaIdentifier.init(_:).
  • Changed AnyMediaIdentifier.init(_:) to prevent from being duplicated.

Improvements

  • Added AnyMediaIdentifier.as(_:) for casting.
  • Added completions to some methods.
  • Improved some doc comments.
  • Improved demo.

@jrsaruo jrsaruo added the maintenance Maintenance such as refactoring, tests or CI label Nov 29, 2023
@jrsaruo jrsaruo self-assigned this Nov 29, 2023
@jrsaruo jrsaruo merged commit 7fa4d65 into feature/media-reloading Nov 29, 2023
@jrsaruo jrsaruo deleted the work/tiny-improvements branch November 29, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance such as refactoring, tests or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0