8000 Replace fixed size Figma variables with new `size-fixed` and `spacing-fixed` variables · Issue #4284 · jpmorganchase/salt-ds · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace fixed size Figma variables with new size-fixed and spacing-fixed variables #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pseys opened this issue Oct 11, 2024 · 4 comments
Open

Replace fixed size Figma variables with new size-fixed and spacing-fixed variables #4284

pseys opened this issue Oct 11, 2024 · 4 comments
Assignees
@pseys
Labels
Figma Related to Figma package: theme Theme package

Comments

@pseys
Copy link
Contributor
pseys commented Oct 11, 2024 •
edited
Loading

Following on from the addition of thickness as a foundation as part of #4116 size-bar-small was marked for deprecation and aliased to thickness-200.

The size-bar-small variable needs to be removed. Any uses of this token should then revert to thickness-200.

Once published, the Spinner component needs to be checked in Figma to ensure the change has taken effect, as this is the only component that references the variable.
@pseys pseys self-assigned this Oct 11, 2024
@pseys pseys converted this from a draft issue Oct 11, 2024
@pseys pseys added package: theme Theme package role: design 🎨 Figma Related to Figma labels Oct 11, 2024
@pseys pseys mentioned this issue Oct 11, 2024
Open
@mark-tate
Copy link
Contributor

Lungo Goal: @bhoppers2008 to unblock by EOS

@joshwooding
Copy link
Contributor

Moved to Macchiato sprint. No capacity in Lungo

@bhoppers2008
Copy link
Contributor

Related to thickness work. Moved to Q2. @pseys

@pseys
Copy link
Contributor Author
pseys commented Apr 1, 2025

Thickness replaced with size-fixed

@pseys pseys changed the title Remove size-bar-small variable in Figma Replace fixed size Figma variables with new size-fixed and spacing-fixed variables Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pseys pseys

Labels
Figma Related to Figma package: theme Theme package
Projects
Salt - Components, Patterns and Theming
Status: Planned
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mark-tate @joshwooding @bhoppers2008 @pseys
0