8000 Add `size-fixed` token ramp to Size foundation · Issue #4116 · jpmorganchase/salt-ds · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add size-fixed token ramp to Size foundation #4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mark-tate opened this issue Sep 16, 2024 · 18 comments
Open

Add size-fixed token ramp to Size foundation #4116

mark-tate opened this issue Sep 16, 2024 · 18 comments
Labels
extended styling

Comments

@mark-tate
Copy link
Contributor
mark-tate commented Sep 16, 2024 •
edited by pseys
Loading

Description:

  • Replaces any --size tokens that are currently fixed across densities; size-border, size-border-strong, and size-bar-strong

Actions

  • Foundational ramp added and replaced tokens deprecated
  • Replace any use of the deprecated tokens with the relevant new thickness tokens
@joshwooding joshwooding added the package: theme Theme package label Sep 16, 2024
@mark-tate
Copy link
Contributor Author

Frappe Goal: defined by EOS

@dplsek
Copy link
dplsek commented Sep 17, 2024

09/17 meeting notes with @dplsek @origami-z @ivan-calderon @pseys

All components currently using border or border-strong that need to be updated… border-stronger is not in code or being used

Core:

  1. Accordion
  2. Banner
  3. Button
  4. Card
  5. Checkbox
  6. Dialog
  7. Divider
  8. Drop-down
  9. File drop zone
  10. Flex layout
  11. Input
  12. Interactable card
  13. Link card
  14. List box
  15. Menu
  16. Multi-line input
  17. Option (used in list box, combo box, and drop-down)
  18. Overlay
  19. Pill input
  20. Progress (circular and linear)
  21. Radio button
  22. Segmented button group
  23. Stack layout
  24. Switch
  25. Tag
  26. Toast
  27. Toggle button group
  28. Tool tip

Lab:

  1. Calendar
  2. Date picker
  3. Slider
  4. Stepped tracker
  5. Tab

Bar-small is only used in spinner, so it would just need to be updated with thickness-200

Border would need to become thickness-100

Border-strong would need to become thickness-200

Definition of thickness for foundation page
Thickness could be used to define the weight of something or the gap between things when the desired result is not to scale across densities.

  • Example of weight is borders on containers
  • Example of gap is the (span, distance, interval) between stepper buttons

This was referenced Sep 17, 2024
Open
Open
Open
Open
@mark-tate
Copy link
Contributor Author

Frappe Goal : dev ready by EOS ? @dplsek

@mark-tate
Copy link
Contributor Author

@origami-z should we move this out of Galao and bring in the ones we are working on @pseys
Galao Goal: cleanup issues

@origami-z
Copy link
Contributor

4 issues are split and created above. Previous sprint goal is dev ready. If those are done, then this issue should be renamed and mark as done. I don't think we have dev capacity for doing this this sprint.

@mark-tate
Copy link
Contributor Author

by EOS we need to know how we will deprecate tokens @pseys

@pseys
Copy link
Contributor
pseys commented Oct 11, 2024 •
edited
Loading

In Figma I will do the following:

  • change border to thickness-100
  • change border-strong to thickness-200
  • change border-stronger to thickness-400
  • change bar-small to reference border-strong
  • Mark bar-small for deprecation

In addition the following will be added:

  • thickness-300 = 3px
  • thickness-500 = 5px
  • thickness-600 = 6px
  • thickness-700 = 7px
  • thickness-800 = 8px
  • thickness-900 = 9px

A new issue will be added to GH to remove bar-small in a future sprint. This will revert it to thickness-200 (previously border-strong).

cc @origami-z @dplsek

@pseys pseys mentioned this issue Oct 11, 2024
Open
@pseys
Copy link
Contributor
pseys commented Oct 11, 2024

#4284 has been created to handle the removal of bar-small in Figma variables.

@pseys pseys mentioned this issue Oct 11, 2024
Open
@pseys
Copy link
Contributor
pseys commented Oct 11, 2024

A branch has been created in Figma with the agreed changes. However, @bhoppers2008 has raised a concern regarding the release of this and how we align to code. We need to hold off on merging and publishing until we have an agreed plan in place.

@bhoppers2008
Copy link
Contributor
bhoppers2008 commented Oct 14, 2024 •
edited by mark-tate
Loading

Latte Goal: Can we prepare an news post to explain what we are releasing and how we will be using it that we can announce at the same time.

@pseys
Copy link
Contributor
pseys commented Oct 14, 2024

Latte Goal: Can we prepare an news post to explain what we are releasing and how we will be using it that we can announce at the same time.

I've created #4285 for this.

@pseys
Copy link
Contributor
pseys commented Oct 22, 2024

First draft of product announcement has been written and shared with @bhoppers2008 for review.

I've also shared pros and cons for the different ways we could roll out the change in Figma. Awaiting Ben's feedback on both.

@dplsek
Copy link
dplsek commented Oct 25, 2024

@pseys has added it into variables but needs to figure out the best approach to more forward with pending discussions with @bhoppers2008

@mark-tate
Copy link
Contributor Author

Latte goal: @bhoppers2008 story blocked until we have a conversation on the required approach
Add goal here, once un-blocked.

@mark-tate mark-tate mentioned this issue Oct 28, 2024
Open
1 task
@joshwooding
Copy link
Contributor

Moved to Macchiato sprint. No capacity in Lungo

@mark-tate
Copy link
Contributor Author

Macc Goal: decision by EOS on how we implement in Figma and manage deprecation
Can we fix Circular progress and move this work to Q1 ?
@ivan-calderon to share with @bhoppers2008 the current state

@origami-z
Copy link
Contributor

Take off assignee and sprint, leave in Q4, see #3978 (comment)

@pseys pseys changed the title Create thickness ramp for borders Create thickness ramp Mar 7, 2025
@pseys pseys added extended styling and removed package: theme Theme package labels Mar 7, 2025
This was referenced Mar 7, 2025
Open
Open
@pseys pseys changed the title Create thickness ramp Add size-fixed token ramp to Size foundation Apr 1, 2025
@pseys
Copy link
Contributor
pseys commented Apr 1, 2025

Following discussion with @origami-z and @dplsek have agreed to change thickness to size-fixed

@origami-z origami-z mentioned this issue Apr 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extended styling
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mark-tate @origami-z @joshwooding @bhoppers2008 @pseys @dplsek
0