8000 Deck Layout · Issue #368 · jpmorganchase/salt-ds · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Deck Layout #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoanaMMoreira opened this issue Sep 1, 2022 · 7 comments · Fixed by #292 or #391
Closed

Deck Layout #368

JoanaMMoreira opened this issue Sep 1, 2022 · 7 comments · Fixed by #292 or #391
Labels
component: deck layout priority: low 😴 type: component 📦 Related to components

Comments

@JoanaMMoreira
Copy link
Contributor
JoanaMMoreira commented Sep 1, 2022 •
edited by joshwooding
Loading 
### Features
- [ ] Navigate backwards and forwards with an slide animation

### Checklist
- [ ] Density (HD, MD, LD, TD)
- [ ] Mode (Light, Dark)
- [ ] Fill (Primary, Secondary, Tertiary)
- [ ] State (Default, Hover, Selected/Active, Disabled, Read-only, Other)
- [ ] Controlled API
- [ ] UITK accessibility parity (screen reader + keyboard interactions)

### Deliverables
- [ ] Characteristics spec
- [ ] Interactions spec, where necessary
- [ ] In Code & Figma (Component + Guide)
- [ ] Supporting site documentation
@JoanaMMoreira JoanaMMoreira self-assigned this Sep 1, 2022
@JoanaMMoreira JoanaMMoreira added this to the MVP - Essential Components - Batch 2 milestone Sep 1, 2022
@JoanaMMoreira JoanaMMoreira linked a pull request Sep 1, 2022 that will close this issue
Update layer layout and carousel storybook examples, remove border from layer and add animations to layer layout #292
Merged
@JoanaMMoreira JoanaMMoreira reopened this Sep 7, 2022
@JoanaMMoreira JoanaMMoreira linked a pull request Sep 8, 2022 that will close this issue
Move layer and deck layout components to core #391
Merged
@joshwooding joshwooding removed a link to a pull request Sep 12, 2022
Move layer and deck layout components to core #391
Merged
@joshwooding joshwooding mentioned this issue Sep 12, 2022
Merged
@joshwooding joshwooding linked a pull request Sep 12, 2022 that will close this issue
Move layer and deck layout components to core #391
Merged
@JoanaMMoreira JoanaMMoreira reopened this Sep 12, 2022
@maj-stella
Copy link

Carousel example:

DeckLayout contains DeckItems. Each DeckItem is used as a slide container therefore the following aria role and attributes should be available on DeckItem:

role="group"
aria-roledescription="slide"
aria-labelledby if a slide has a visible label otherwise aria-label

@maj-stella maj-stella self-assigned this Sep 26, 2022
@maj-stella
Copy link

Tabs example:

When DeckItem is used as tab panel, it should have role=“tabpanel” (please see the screenshot below). When the tabpanel does not contain a focusable element as the first element, the tabpanel should have availability to set tabindex="0" to include tabpanel in the tab sequence of the page.

Each DeckItem (tabpanel) should have available aria-labelledby attribute. (Value of aria-labelledby is id value of each tab).

Also each DeckItem (tabpanel) should have available id attribute so it can be associated with tab by aria-controls attribute.

Image

@joshwooding joshwooding modified the milestones: Simple Form, Layouts Oct 4, 2022
@JoanaMMoreira
Copy link
Contributor Author

Hi @maj-stella please see the changes I've made here: https://deck-ada-tweaks.uitk.pages.dev/

@joshwooding joshwooding removed this from the Layouts milestone Feb 7, 2023
@origami-z origami-z moved this from Green to Planned in Salt - Components, Patterns and Theming Oct 3, 2023
@mark-tate mark-tate mentioned this issue Jul 8, 2024
Open
@mark-tate
Copy link
Contributor

review this earlier defect created on Labs
#2558

@mark-tate mark-tate added the type: component 📦 Related to components label Jul 9, 2024
@mark-tate
Copy link
Contributor

Needed for carousel pattern

@bhoppers2008
Copy link
Contributor

Carousel may end up as a component, not a pattern. Needs a discussion about how useful deck layout is if carousel is a component.

@mark-tate
Copy link
Contributor

No longer plan to build as was only used by Carousel which has it's own solution.
If you need this, please create a new ticket with your use-case defined.

@mark-tate mark-tate closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: deck layout priority: low 😴 type: component 📦 Related to components
Projects
Salt - Components, Patterns and Theming
Status: Planned
Milestone
No milestone
6 participants
@mark-tate @joshwooding @Fercas123 @JoanaMMoreira @bhoppers2008 @maj-stella
0