8000 Carousel component · Issue #2437 · jpmorganchase/salt-ds · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Carousel component #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dplsek opened this issue Sep 12, 2023 · 25 comments
Open

Carousel component #2437

dplsek opened this issue Sep 12, 2023 · 25 comments
Assignees
@Fercas123 @jake-costa @ivan-calderon
Labels
priority: low 😴 type: pattern 🧩 Related to patterns UITK: parity OKR

Comments

@dplsek
Copy link
dplsek commented Sep 12, 2023 •
edited by ivan-calderon
Loading

Description

TBD.

Tasks

### Checklist
- [x] Density (HD, MD, LD, TD)
- [ ] Mode (Light, Dark)

### Deliverables
- [x] Characteristics spec
- [x] Interactions spec, where necessary
- [ ] In Code & Figma (Component + Guide)
- [ ] Supporting site documentation
@origami-z origami-z moved this from Green to Planned in Salt - Components, Patterns and Theming Oct 3, 2023
@shinytoyrobots
Copy link
Contributor

Carousels are bad patterns - I don't think this is something that we should define or build, as doing so puts a design system approval on a fundamentally flawed UX.

@joshwooding joshwooding changed the title Create pattern for carousel Carousel pattern Jan 5, 2024
@mark-tate mark-tate changed the title Carousel pattern Carousel pattern (Publish Pattern to Site) Apr 17, 2024
@mark-tate mark-tate changed the title Carousel pattern (Publish Pattern to Site) Carousel pattern (Publish to Site) Apr 17, 2024
@origami-z
Copy link
Contributor

Bump to Q3, need more tech consideration before publish examples

@mark-tate
Copy link
Contributor
mark-tate commented Jul 8, 2024 •
edited
Loading

Assume it depends on Deck layout #368

@bhoppers2008
Copy link
Contributor

Needs discussion about whether carousel is a component or pattern. Related to #368

@mark-tate
Copy link
Contributor

Tecno Goal: kickoff for this sprint

Decide whether a component or a pattern
Review Pepper

@mark-tate
Copy link
Contributor

It's a component.

Aligning the old Carousel implementation with latest standards and removing DeckLayout from our Carousel.
DeckLayout will remain in Labs.

Call required with @ivan-calderon to align visuals.

@ivan-calderon ivan-calderon self-assigned this Jan 28, 2025
@mark-tate
Copy link
Contributor

Refactoring into a composable solution
Technical approach to be agreed by EOS, minimum design to be agreed by EOS

@mark-tate
Copy link
Contributor

Oregano Goal
Publish pattern by EOS

@mark-tate
Copy link
Contributor

catchup today to align the design with the implementation

@mark-tate
Copy link
Contributor
mark-tate commented Feb 10, 2025 •
edited
Loading

refining the alignment of design and code

If you need this component, then let us know as we are looking for stakeholder reviews

@mark-tate
Copy link
Contributor
mark-tate commented Feb 12, 2025 •
edited by ivan-calderon
Loading

On track

c.c. @joshwooding

@joshwooding joshwooding changed the title Carousel pattern (Publish to Site) Carousel component Feb 17, 2025
@bhoppers2008
Copy link
Contributor

Update: Build ready for dev and ada review (@jake-costa)
Cumin goal: Move to labs by end of sprint (needs documentation @ivan-calderon and tests).

@joshwooding
Copy link
Contributor

@Fercas123 investigating a bug around resizing, tests have been written and @jake-costa has given feedback. Meeting later to go over the rest of the feedback.

@mark-tate
Copy link
Contributor

ontrack

@jake-costa
Copy link
Contributor

Meeting on Feb 26 to discuss:
screen reader announcement after Previous/Next button is pressed
dragging/scrolling for mobile
Focus indicator cutoff on button

@Fercas123

@mark-tate
Copy link
Contributor

Paprika: Labs by end of wk1
targetting core by end of Q1
Site documentation to be published in Paprika

@mark-tate
Copy link
Contributor

Labs version to be reviewed by EOS

@bhoppers2008 bhoppers2008 mentioned this issue Mar 12, 2025
Closed
@mark-tate
Copy link
Contributor

in PR

@mark-tate
Copy link
Contributor

Cayenne Goal: working on code review feedback
Go/no-go decision to Core at EOS.

@mark-tate
Copy link
Contributor

Review for merge to Labs ?
Cardoman Goal: Core decision in next sprint.

@mark-tate
Copy link
Contributor

Clove Goals: reviewed by stakeholders

  1. interactive content example to be added
  2. hotspots over images
  3. title placement (left and right options)
  4. Draggable (may come as a second iteration)
  5. Light box (what types of images can be put in there)

Review above and understand what we can do now (through docs) and what needs to be a follow up iteration.

@Fercas123
Copy link
Contributor

interactive content example to be added - WIP
title placement (left and right options) - TBD (@ivan-calderon we should discuss this possibility)

hotspots over images - #5045
Draggable - #5031
Light box - #5030

@origami-z
Copy link
Contributor

May 1 - updates to examples WIP

@origami-z
Copy link
Contributor
origami-z commented May 1, 2025 •
edited
Loading

MTK feedback

Issue 1

From carousel -> zoomed carousel, the index is correct. But from zoomed carousel -> carousel, the index always reverts back to the previous state. NOTE - this revert does not happen when you click outside to close the dialog. It only happens when you click the X button to close the Carousel.

Issue 2

Some cards jump to the right by 1px which means the right border is not visible on those cards. You can see the issue happening in the same gif as issue 1 (notice the absence of the right border in slide 2 and slide 4).

This can be seen on appearance example when moving to slide 4 for bordered one

@mark-tate
Copy link
Contributor

Allspice goal: fix issues, re-visit Core release date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fercas123 Fercas123

@jake-costa jake-costa

@ivan-calderon ivan-calderon

Labels
priority: low 😴 type: pattern 🧩 Related to patterns UITK: parity OKR
Projects
Salt - Components, Patterns and Theming
Status: Planned
Milestone
No milestone
Development

No branches or pull requests
9 participants
@mark-tate @shinytoyrobots @origami-z @joshwooding @Fercas123 @jake-costa @bhoppers2008 @dplsek @ivan-calderon
0