8000 Ohior impl3 by Ohior · Pull Request #34 · joreilly/GeminiKMP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ohior impl3 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 17, 2025
Merged

Ohior impl3 #34

merged 14 commits into from
Apr 17, 2025

Conversation

Ohior
Copy link
Contributor
@Ohior Ohior commented Apr 6, 2025

This new update has sqldelight database and timestamp for the time the message was sent. And some UI improvements.

@Ohior
Copy link
Contributor Author
Ohior commented Apr 6, 2025

Hello Joreilly 👋. how are you doing
I just want to let you know that the app now has all that I need and that I probably, maybe, not 100% sure won’t be making any more in the future. It was nice working with you, and I think I like this experience. It was fun, even though I do not know you 😁.
That been said, I will look forward to working with you in the future, Don't hesitate to reach out to me if you need my expertise, I don't just do Kotlin I also do Python and Dart(Flutter) as well.

Sincerely me 🐵 Ohior

@joreilly
Copy link
Owner
joreilly commented Apr 6, 2025

Looks like you've commented out Wasm related code? And also CI github actions.

@Ohior
Copy link
Contributor Author
Ohior commented Apr 6, 2025

Looks like you've commented out Wasm related code?

Web still works. Sql delight require jsMain so I switch wasmMain to jsMain. But nothing changed. Web still works

@joreilly
Copy link
Owner
joreilly commented Apr 6, 2025

Yes, but I'm specifically targeting Kotlin/Wasm based Compose for Web client in this (and other) projects. This is where Jetbrains is focussing their support for now.

@joreilly
Copy link
Owner
joreilly commented Apr 6, 2025

Also, I'd generally advise against commenting out Github CI actions.....they're important safety net to ensure PRs don't break any existing code.

@joreilly
Copy link
Owner
joreilly commented Apr 6, 2025

I'll try and get some time and get PR in state in can be merged. An alternative if you want to proceed with changes you have is to create fork of the project and makes the changes there.

@Ohior
Copy link
Contributor Author
Ohior commented Apr 6, 2025

Yes, but I'm specifically targeting Kotlin/Wasm based Compose for Web client in this (and other) projects. This is where Jetbrains is focussing their support for now.

Sql delight for JS is stable. But they did say there will be wasm in the future.
I checked for the one that supports wasm and I saw "multiplatform settings", it is not a database per say, but more of like a shared preference storage with key and value. And it is not efficient to store chats data on shared preference.
About the github actions. I didn't comment it this time.

@Ohior
Copy link
Contributor Author
Ohior commented Apr 15, 2025

So I use sql-delight before and T had to change the wasmJsMain to jsMain, then you said the app is supposed to use wasm not js. Since all KMP database uses js and those that does not use js does not support all platform. I created the database and save the data in json format. and the data gets saved locally. The database is a NO-SQL.
There was also the issue of when you change theme your chat history gets deleted, minor, but I also fixed that

@joreilly
Copy link
Owner
joreilly commented Apr 15, 2025

About the github actions. I didn't comment it this time.

It looks like android.yml and ios.yml are still deleted in the PR.....can you revert those deletions so associated GH actions can run for the PR.

@Ohior
Copy link
Contributor Author
Ohior commented Apr 16, 2025

About the github actions. I didn't comment it this time.

It looks like android.yml and ios.yml are still deleted in the PR.....can you revert those deletions so associated GH actions can run for the PR.

I added the android.yml and ios.yml and the also fixed android expect bug that wasn't implemented

@Ohior
Copy link
Contributor Author
Ohior commented Apr 17, 2025

Hello @joreilly
I have made a PR, check it out. Plus all the git hub action is fixed.

@joreilly joreilly merged commit 5557f04 into joreilly:main Apr 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0