-
Notifications
You must be signed in to change notification settings - Fork 28
Ohior impl3 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ohior impl3 #34
Conversation
Hello Joreilly 👋. how are you doing Sincerely me 🐵 |
Looks like you've commented out Wasm related code? And also CI github actions. |
Web still works. Sql delight require jsMain so I switch wasmMain to jsMain. But nothing changed. Web still works |
Yes, but I'm specifically targeting Kotlin/Wasm based Compose for Web client in this (and other) projects. This is where Jetbrains is focussing their support for now. |
Also, I'd generally advise against commenting out Github CI actions.....they're important safety net to ensure PRs don't break any existing code. |
I'll try and get some time and get PR in state in can be merged. An alternative if you want to proceed with changes you have is to create fork of the project and makes the changes there. |
Sql delight for JS is stable. But they did say there will be wasm in the future. |
So I use sql-delight before and T had to change the wasmJsMain to jsMain, then you said the app is supposed to use wasm not js. Since all KMP database uses js and those that does not use js does not support all platform. I created the database and save the data in json format. and the data gets saved locally. The database is a NO-SQL. |
It looks like |
I added the android.yml and ios.yml and the also fixed android expect bug that wasn't implemented |
Hello @joreilly |
This new update has sqldelight database and timestamp for the time the message was sent. And some UI improvements.