Add new flag (--fpm-options-file) to allow reading additional options from a file. #1905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey, just following up on the PR's status. thanks for the |
|
@hjpotter92 I haven't worked much on this, but I Hope to resume soon :) |
This option flag will cause fpm to load additional flags, in place, from the given file. For example, if a file "foo" contains one line, "--version 5.10", then `fpm -s empty -t deb -n example --fpm-options-file foo` act as if `--version 5.10` was given on the command-line in the same position as the `--fpm-options-file` flag. Error conditions checked: * Has the file already been loaded? * Does the file exist? * Is the file readable? No tests included at this time. This code is likely missing some edge cases (combined single-letter flags, multiple flag entries on a line, etc).
Cases: * Option ordering (the flag operates in-place) * Multiple --long-flags on a single line * Multiple single flags on a single line (both like '-ff' and '-f -f') * File self-reference errors
123610f to
4f02f76
Compare
|
@hjpotter92 Added some extra tests tonight on top of the previous work which was already pretty much complete! Merged :) |
|
fpm 1.15.0 released with this new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1902 and #1827.