feat(mj-font): add fonts option #90
Conversation
| | Name | Comment | Default value | | ||
| |----------------------|------------------------------------------------------|------------------------------------------------------------------------------------------------------| | ||
| | `disable_comments` | Strip comments out of rendered HTML | `false` | | ||
| | `social_icon_origin` | Custom URL for fetching social icons | `None` | |
There was a problem hiding this comment.
Maybe the format of the ressource at the URL should be specified here. Also I noticed that the default URL returns an error. This probably should be checked.
There was a problem hiding this comment.
Thanks for spotting this, I created an issue here to track this 😉
6ab0b1a to
fcaf7f8
Compare
docs: document options
fcaf7f8 to
dadd4b9
Compare
docs: document options
dadd4b9 to
ffad69a
Compare
|
I am sorry, I don't get what is the problem with the semantic PR check… |
|
@jdrouet Sorry to mention you but we need this feature for a project and this PR should be easy to review. |
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
|
@jdrouet Thank you very much. Would you agree to push a release? |
|
👍 I'll push that tonight or tomorrow 😉 |
|
@christophehenry with a bit of delay, I published a new version 😉 |
|
Awesome! Thx! |
|
I'm sorry, I don't see |
Also add a documentation on what options are available.
Fixes #88