8000 feat(prelude parse): mark IncludeLoaderError cayse as Send and Sync by jdrouet · Pull Request #52 · jolimail/mrml-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jul 25, 2023. It is now read-only.

feat(prelude parse): mark IncludeLoaderError cayse as Send and Sync #52

Merged
merged 1 commit into from
Mar 25, 2023
Merged

feat(prelude parse): mark IncludeLoaderError cayse as Send and Sync #52

merged 1 commit into from
Mar 25, 2023

Conversation

jdrouet
Copy link
Contributor
@jdrouet jdrouet commented Mar 12, 2023

This changes the cause field in IncludeLoaderError to be Send + Sync + 'static as requested per #45 .

@jdrouet
feat(prelude parse): mark IncludeLoaderError cayse as Send and Sync
9dabec1 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@jdrouet
Copy link
Contributor Author
jdrouet commented Mar 12, 2023

@LeoniePhiline tell me if this is what you needed 😉

@codecov
Copy link
codecov bot commented Mar 12, 2023

Codecov Report

Merging #52 (9dabec1) into main (7f60579) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   94.54%   94.52%   -0.02%     
==========================================
  Files         213      213              
  Lines       10577    10579       +2     
==========================================
  Hits        10000    10000              
- Misses        577      579       +2
Impacted Files Coverage Δ
src/prelude/parse/loader.rs 88.46% <25.00%> (-2.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LeoniePhiline
Copy link

@jdrouet Hey, thanks a lot!
I'm not home right now - will be back in a few days. Would it be okay for you to keep this PR pending until then? I'll test it once I get home.

@jdrouet
Copy link
Contributor Author
jdrouet commented Mar 22, 2023

ping @LeoniePhiline

@LeoniePhiline LeoniePhiline mentioned this pull request Mar 24, 2023
Closed
@LeoniePhiline
Copy link

Dear Jérémie, thanks for your patience!
I am sorry, I was in a project-crunch in the last weeks, that also lasted a few weeks longer than expected.

I checked 9dabec1 right now, and I can confirm #45 is fixed! Thank you so much!

I promise, next time I'll prepare a PR myself and not have you do the work. 💛 Again, thank you.

@jdrouet jdrouet merged commit 14e1ba4 into main Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdrouet @LeoniePhiline
0