8000 feat(mj-include): first implementation of mj-include by jdrouet · Pull Request #23 · jolimail/mrml-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jul 25, 2023. It is now read-only.

feat(mj-include): first implementation of mj-include #23

Merged
merged 13 commits into from
Feb 4, 2023
Merged

feat(mj-include): first implementation of mj-include #23

merged 13 commits into from
Feb 4, 2023

Conversation

jdrouet
Copy link
Contributor
@jdrouet jdrouet commented Jan 27, 2023 •
edited
Loading

This PR intends to add support for mj-include as requested by jdrouet/mrml#61

@jdrouet jdrouet self-assigned this Jan 27, 2023
@jdrouet jdrouet added the enhancement New feature or request label Jan 27, 2023
@jdrouet jdrouet linked an issue Jan 27, 2023 that may be closed by this pull request
Implement the mj-include component #8
Closed
@jdrouet
feat(mj-include): create component with parse method
20a4498 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@jdrouet
feat(mj-include): add parser options to every parser
e43f7a6 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@jdrouet
feat(mj-include): implement parse method
a8a7b1f 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@jdrouet
feat(mj-include): implement json feature
7b4eeb8 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@jdrouet
feat(mj-include): implement print feature
bf0211a 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@jdrouet
feat(mj-include): implement simple render
08446fe 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@jdrouet
feat(mj-include): implement type=html
8f4adb5 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@jdrouet
feat(mj-include): add css inline for mj-include
7cdb9c5 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@jdrouet
feat(mj-include): split mj-include for head and body
77200a3 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@codecov-commenter
Copy link
codecov-commenter commented Feb 3, 2023 •
edited by codecov bot
Loading

Codecov Report

Merging #23 (ffdb63a) into main (f2f6364) will decrease coverage by 1.30%.
The diff coverage is 83.69%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   94.90%   93.61%   -1.30%     
==========================================
  Files         198      211      +13     
  Lines        8968     9986    +1018     
==========================================
+ Hits         8511     9348     +837     
- Misses        457      638     +181
Impacted Files Coverage Δ
src/mj_accordion/mod.rs 100.00% <ø> (ø)
src/mj_accordion_element/children.rs 5.26% <0.00%> (-1.41%) ⬇️
src/mj_body/children.rs 96.87% <0.00%> (+0.10%) ⬆️
src/mj_breakpoint/mod.rs 100.00% <ø> (ø)
src/mj_head/children.rs 100.00% <ø> (ø)
src/mjml/mod.rs 93.33% <ø> (ø)
src/text/json.rs 91.17% <ø> (-0.26%) ⬇️
src/lib.rs 10.00% <14.28%> (-15.00%) ⬇️
src/prelude/parse/loader.rs 48.48% <48.48%> (ø)
src/mj_include/body/parse.rs 67.40% <67.40%> (ø)
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jdrouet
chore(mj-include): apply clippy suggestions
536fcad 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@jdrouet
chore(mj-accordion): add some tests
219bd30 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@jdrouet
chore(mj-include): add some doc
5f8505e 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@jdrouet
chore(mj-accordion): add some doc
ffdb63a 
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@jdrouet jdrouet marked this pull request as ready for review February 4, 2023 20:14
@jdrouet jdrouet merged commit 57cd747 into main Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jdrouet jdrouet

Labels
enhancement New feature or request
Projects
mrml
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the mj-include component
2 participants
@jdrouet @codecov-commenter
0