10000 add toolbar versions button by alikon · Pull Request #40 · joomla-projects/joomla-cypress · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add toolbar versions button #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 9, 2025
Merged

add toolbar versions button #40

merged 5 commits into from
Jan 9, 2025

Conversation

alikon
Copy link
Contributor
@alikon alikon commented Dec 29, 2024

Added toolbar versions button

can be used like:

cy.clickToolbarButton('Versions');

@muhme
Copy link
Contributor
muhme commented Dec 29, 2024

Can I get you to add a test for this new button? 😄

And you or I could improve the documentation with all the different clickToolbarButton buttons. What do you think?

@alikon
Copy link
Contributor Author
alikon commented Dec 29, 2024

this is the pr for the test using the button joomla/joomla-cms#44675

@muhme
Copy link
Contributor
muhme commented Dec 29, 2024

is is the pr for the test using the button joomla/joomla-cms#44675

Yes and I meant in the joomla-cypress testsuite itself, in the file tests/e2e/support.cy.js, in the test it(‘clickToolbarButton()’ - just to familiarise yourself with the joomla-cypress testsuite

@alikon
Copy link
Contributor Author
alikon commented Jan 3, 2025

done
when you have time please check

@muhme
Copy link
Contributor
muhme commented Jan 4, 2025

Thank you for adding the test! The test works well and I recommend deleting the newly created Test article versions article as the final step. Otherwise, with each test run (if a Joomla installation step is not included) we'll have one more test article.

@laoneo laoneo merged commit 06d6caa into joomla-projects:main Jan 9, 2025
@laoneo
Copy link
Contributor
laoneo commented Jan 9, 2025

Thanks!

@alikon alikon deleted the patch-1 branch January 9, 2025 13:49
muhme added a commit to muhme/joomla-cypress that referenced this pull request Feb 23, 2025
In PR joomla-projects#40 the `clickToolbarButton()` test was introduced, but it always fails with:
```
     CypressError: `cy.task('queryDB')` failed with the following error:

The 'task' event has not been registered in the setupNodeEvents method. You must register it before using cy.task()
```

The Cypress custom task `queryDB` from Joomla System Tests is not available in testing joomla-cypress itself.

The error is reproducible when running the overall test suite or the single test:
```
npx cypress run --spec tests/e2e/support.cy.js --config-file tests/cypress.config.mjs
```

This PR manually implements the article deletion process .
Additionally, comments have been added to clarify what is being tested in the clickToolbarButton() test and
unified the button names with an initial uppercase letter, as capitalisation does not matter.
Please ensure that tests are always run after any changes to confirm that everything continues to function correctly.
@muhme muhme mentioned this pull request Feb 23, 2025
laoneo pushed a commit that referenced this pull request Mar 3, 2025
In PR #40 the `clickToolbarButton()` test was introduced, but it always fails with:
```
     CypressError: `cy.task('queryDB')` failed with the following error:

The 'task' event has not been registered in the setupNodeEvents method. You must register it before using cy.task()
```

The Cypress custom task `queryDB` from Joomla System Tests is not available in testing joomla-cypress itself.

The error is reproducible when running the overall test suite or the single test:
```
npx cypress run --spec tests/e2e/support.cy.js --config-file tests/cypress.config.mjs
```

This PR manually implements the article deletion process .
Additionally, comments have been added to clarify what is being tested in the clickToolbarButton() test and
unified the button names with an initial uppercase letter, as capitalisation does not matter.
Please ensure that tests are always run after any changes to confirm that everything continues to function correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0