8000 Install Joomla with non-standard db_port by muhme · Pull Request #33 · joomla-projects/joomla-cypress · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Install Joomla with non-standard db_port #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 30, 2024
Merged

Install Joomla with non-standard db_port #33

merged 6 commits into from
Aug 30, 2024

Conversation

muhme
Copy link
Contributor
@muhme muhme commented Aug 24, 2024

This is one puzzle piece for joomla/joomla-cms#43902 – Installing Joomla with non-standard database port.

In the Joomla System Tests this PR is only working together with joomla/joomla-cms#43968.

With currently (August 2024) Joomla Web Installer it is only working for MariaDB and MySQL. It is not working for PostgreSQL.

Isolated only testable that it does not harm.

You could see this PR is already used as hack in Joomla Branches Tester. There you can see it working in scripts/cypress.sh 44 local and running in the Installation.cy.js step. If you revert the changes in file branch_44/node_modules/joomla-cypress/src/joomla.js the Joomla Web Installer fails with:

Could not connect to the database. Connector returned error message: No such file or directory

This was referenced Aug 24, 2024
Closed
Closed
@laoneo laoneo merged commit 8533937 into joomla-projects:main Aug 30, 2024
@laoneo
Copy link
Contributor
laoneo commented Aug 30, 2024

Thanks!

@alikon
Copy link
Contributor
alikon commented Sep 1, 2024

with joomla-framework/database#310 no more needed

@muhme muhme mentioned this pull request Sep 1, 2024
Merged
@muhme muhme mentioned this pull request Sep 17, 2024
Merged
4 tasks
@muhme
Copy link
Contributor Author
muhme commented Sep 24, 2024

with joomla-framework/database#310 no more needed

I disagree. This 8104 PR is necessary because it translates the db_host and db_port entries from the cypress.config.mjs file into a host:port format, which is then inserted into the 'Enter the host name' field in the Joomla Web Installer. The Web Installer only has a single host field and does not have a dedicated port number field. On the other hand, in the Cypress System Tests configuration, we are working with the host and port separated for the database drivers.

@muhme muhme mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muhme @laoneo @alikon
0