compatibility with other mods (mainly pipeworks) #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't figure out a way to access real player metadata, the idea pleases me as it would allow nodebreakers to take in account the "lumberjack privilege", or to add a setting on the way non real players behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-03-28 14:01:09: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod '' in callback environment_Step(): /home/sam/.minetest/mods/lumberjack/init.lua:128: attempt to call method 'get_meta' (a nil value)
nodebreaker don't have a get_meta function so the mod lumberjack crashes the server.
the workaround I propose always give the old lumberjack "priv" to the nodebreaker (is_lumberjack returns -1,-1)
also this pr fixes diamond axe case where cap.choppy = 3, the old test was < 3, new is <=3