8000 Add `company_prefix` fields to GLN, GTIN, and SSCC classes by jodal · Pull Request #174 · jodal/biip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add company_prefix fields to GLN, GTIN, and SSCC classes #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2022

Conversation

jodal
Copy link
Owner
@jodal jodal commented Dec 18, 2022

This is the final piece building upon PR #172. This PR adds and sets a
company_prefix field on the Gtin, Gln, and Sscc classes.

Fixes #160

@jodal jodal self-assigned this Dec 18, 2022
@jodal jodal force-pushed the jodal/company-prefix-fields branch from c1bc40f to 896d5b8 Compare December 18, 2022 23:49
@codecov
Copy link
codecov bot commented Dec 18, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (c1bc40f) compared to base (2183e75).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head c1bc40f differs from pull request most recent head 896d5b8. Consider uploading reports for the commit 896d5b8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #174   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          911       916    +5     
  Branches       147       147           
=========================================
+ Hits           911       916    +5     
Impacted Files Coverage Δ
src/biip/__init__.py 100.00% <ø> (ø)
src/biip/gs1/__init__.py 100.00% <ø> (ø)
src/biip/gs1/_element_strings.py 100.00% <ø> (ø)
src/biip/gtin/__init__.py 100.00% <ø> (ø)
src/biip/gln.py 100.00% <100.00%> (ø)
src/biip/gtin/_gtin.py 100.00% <100.00%> (ø)
src/biip/sscc.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jodal jodal merged commit a0c301c into main Dec 18, 2022
@jodal jodal deleted the jodal/company-prefix-fields branch December 18, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract GCP
1 participant
0