Pass AbstractSets to Transaction #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacoob
reviewed
Jul 28, 2024
beancount-stubs/core/data.pyi
Outdated
| @@ -129,8 +130,8 @@ class Transaction: | |||
| flag: Flag | |||
| payee: Optional[str] | |||
| narration: str | |||
| tags: Optional[set] | |||
| links: Optional[set] | |||
| tags: FrozenSet | |||
There was a problem hiding this comment.
Ah, joke's on me—when I said "matches upstream code" I was looking at master.
How about:
Suggested change
| tags: FrozenSet | |
| tags: FrozenSet | set |
Or, although that allow_none_for_tags_and_links switch defaults to False:
Suggested change
| tags: FrozenSet | |
| tags: FrozenSet | set | None |
There was a problem hiding this comment.
I'd say let's go with None being a part of the set. And no worries about the branch mismatch, been in the same position a week ago, writing my own importer... :)
There was a problem hiding this comment.
Actually, since I'm annotating args, the docs say I should use AbstractSet.
>>> from typing import AbstractSet
>>> issubclass(set, AbstractSet)
True
>>> issubclass(frozenset, AbstractSet)
TrueAlthough AbstractSet is deprecated since 3.9, most of typing is too, so I won't worry about that yet.
Should I fix Document accordingly in this or another PR?
5b4828c to
5872994
Compare
This way, `frozenset`s (like `EMPTY_SET`) are considered valid. They're `Optional` because Beancount can occasionally be convinced to allow `None`s into these fields: https://github.com/beancount/beancount/blob/2.3.6/beancount/core/data.py#L500-L502
yacoob
pushed a commit
that referenced
this pull request
Aug 5, 2024
This way, `frozenset`s (like `EMPTY_SET`) are considered valid. They're `Optional` because Beancount can occasionally be convinced to allow `None`s into these fields: https://github.com/beancount/beancount/blob/2.3.6/beancount/core/data.py#L500-L502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches upstream code. Fixes #4.