8000 refactor: rename some convert functions by hanxiao · Pull Request #3836 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: rename some convert functions #3836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2021
Merged

refactor: rename some convert functions #3836

merged 1 commit into from
Oct 30, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Oct 30, 2021

No description provided.

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/jaml component/type labels Oct 30, 2021
@codecov
Copy link
codecov bot commented Oct 30, 2021 •
edited
Loading

Codecov Report

Merging #3836 (d919c06) into master (1166f1f) will decrease coverage by 2.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3836      +/-   ##
==========================================
- Coverage   89.42%   86.61%   -2.81%     
==========================================
  Files         156      156              
  Lines       12198    12210      +12     
==========================================
- Hits        10908    10576     -332     
- Misses       1290     1634     +344
Flag Coverage Δ
daemon 44.42% <73.91%> (+0.12%) ⬆️
jina 86.14% <100.00%> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/jaml/parsers/__init__.py 92.85% <ø> (ø)
jina/__init__.py 71.60% <100.00%> (+0.35%) ⬆️
jina/helloworld/multimodal/my_executors.py 76.92% <100.00%> (-20.00%) ⬇️
jina/types/arrays/neural_ops.py 88.88% <100.00%> (ø)
jina/types/document/converters.py 78.61% <100.00%> (+0.80%) ⬆️
jina/helloworld/multimodal/app.py 0.00% <0.00%> (-86.80%) ⬇️
jina/peapods/pods/k8slib/kubernetes_tools.py 67.41% <0.00%> (-29.22%) ⬇️
jina/peapods/networking.py 58.33% <0.00%> (-28.44%) ⬇️
jina/peapods/pods/k8s.py 62.53% <0.00%> (-18.74%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4353290...d919c06. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1268, delta to last 2 avg.: +13%
  • 🐎🐎🐎🐎 query QPS at 64, delta to last 2 avg.: +20%
  • 🐎🐎🐎🐎 dam extend QPS at 48622, delta to last 2 avg.: +17%
  • 🐎🐎🐎🐎 avg flow time within 1.3093 seconds, delta to last 2 avg.: +1%
  • 🐎🐎 import jina within 0.5003 seconds, delta to last 2 avg.: +9%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1268 64 48622 1.3093 0.5003
2.1.13 1138 54 44465 1.4078 0.4552
2.1.12 1089 52 38564 1.1841 0.4604

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 6246c4b into master Oct 30, 2021
@hanxiao hanxiao deleted the refactor-conv-fn branch October 30, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/jaml component/type size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanxiao
0