8000 fix: make accessible shard and replica info at container rt by JoanFM · Pull Request #3822 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make accessible shard and replica info at container rt #3822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 2, 2021
Merged

fix: make accessible shard and replica info at container rt #3822

merged 8 commits into from
Nov 2, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Oct 29, 2021

No description provided.

@JoanFM JoanFM linked an issue Oct 29, 2021 that may be closed by this pull request
ContainerRuntime does not get replica_id or shard_id in runtime_args of Executor #3821
Closed
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/daemon area/testing This issue/PR affects testing labels Oct 29, 2021
@github-actions
Copy link
github-actions bot commented Oct 29, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1461, delta to last 2 avg.: +13%
  • 🐎🐎🐎🐎 query QPS at 69, delta to last 2 avg.: +12%
  • 🐎🐎🐎🐎 dam extend QPS at 61603, delta to last 2 avg.: +18%
  • 🐎🐎🐎🐎 avg flow time within 1.0731 seconds, delta to last 2 avg.: -14%
  • 🐢🐢 import jina within 0.3426 seconds, delta to last 2 avg.: -18%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1461 69 61603 1.0731 0.3426
2.2.2 1231 59 48552 1.1726 0.4288
2.2.1 1352 63 55112 1.3286 0.4151

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM force-pushed the fix-containerruntime-args branch from 2712d9c to a59177c Compare October 29, 2021 08:17
@codecov
Copy link
codecov bot commented Oct 29, 2021 •
edited
Loading
8000

Codecov Report

Merging #3822 (1cf6104) into master (6104e4b) will increase coverage by 0.82%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3822      +/-   ##
==========================================
+ Coverage   89.23%   90.05%   +0.82%     
==========================================
  Files         156      156              
  Lines       12224    12227       +3     
==========================================
+ Hits        10908    11011     +103     
+ Misses       1316     1216     -100
Flag Coverage Δ
daemon 44.30% <50.00%> (+0.01%) ⬆️
jina 88.50% <100.00%> (+1.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/__init__.py 83.65% <100.00%> (ø)
jina/parsers/peapods/pea.py 100.00% <100.00%> (ø)
jina/peapods/pods/__init__.py 89.18% <100.00%> (+3.59%) ⬆️
jina/jaml/__init__.py 95.47% <0.00%> (+0.41%) ⬆️
jina/peapods/runtimes/zmq/zed.py 91.78% <0.00%> (+0.45%) ⬆️
jina/peapods/zmq/__init__.py 89.06% <0.00%> (+0.69%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 83.47% <0.00%> (+0.86%) ⬆️
jina/clients/base/__init__.py 92.75% <0.00%> (+1.44%) ⬆️
jina/types/message/__init__.py 87.37% <0.00%> (+1.45%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf8dc7...1cf6104. Read the comment docs.

@JoanFM JoanFM closed this Oct 29, 2021
@JoanFM JoanFM reopened this Oct 29, 2021
@github-actions github-actions bot added the area/cli This issue/PR affects the command line interface label Oct 29, 2021
@JoanFM JoanFM closed this Oct 29, 2021
@JoanFM JoanFM reopened this Oct 29, 2021
jacobowitz
jacobowitz suggested changes Oct 29, 2021
View reviewed changes
Copy link
Contributor
@jacobowitz jacobowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one leftover from testing, otherwise looks good 👍

jacobowitz
jacobowitz previously approved these changes Oct 29, 2021
View reviewed changes
@JoanFM JoanFM force-pushed the fix-containerruntime-args branch from 6d52868 to 9e67998 Compare October 29, 2021 15:54
@JoanFM JoanFM force-pushed the fix-containerruntime-args branch 2 times, most recently from e22198e to 5449ab6 Compare October 29, 2021 18:36
@JoanFM JoanFM force-pushed the fix-containerruntime-args branch from 5449ab6 to c923470 Compare October 29, 2021 20:13
@JoanFM JoanFM force-pushed the fix-containerruntime-args branch from 7ea9aa9 to ff16f4f Compare October 29, 2021 21:09
@JoanFM JoanFM requested a review from jacobowitz November 1, 2021 19:38
@JoanFM JoanFM merged commit cdadb07 into master Nov 2, 2021
@JoanFM JoanFM deleted the fix-containerruntime-args branch November 2, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobowitz jacobowitz jacobowitz approved these changes

@deepankarm deepankarm Awaiting requested review from deepankarm

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/executor component/peapod executor/meta size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ContainerRuntime does not get replica_id or shard_id in runtime_args of Executor
3 participants
@JoanFM @jacobowitz @jina-bot
0