8000 docs: add small-images-inside-big-images by alaeddine-13 · Pull Request #3828 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: add small-images-inside-big-images #3828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2021
Merged

docs: add small-images-inside-big-images #3828

merged 2 commits into from
Oct 29, 2021

Conversation

alaeddine-13
Copy link
Contributor

closes: #3796

@github-actions github-actions bot added size/L area/docs This issue/PR affects the docs labels Oct 29, 2021
@alaeddine-13 alaeddine-13 requested a review from hanxiao October 29, 2021 13:00
@codecov
Copy link
codecov bot commented Oct 29, 2021 •
edited
Loading

Codecov Report

Merging #3828 (e0847ec) into master (898d157) will increase coverage by 1.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3828      +/-   ##
==========================================
+ Coverage   88.54%   90.09%   +1.55%     
==========================================
  Files         156      156              
  Lines       12104    12105       +1     
==========================================
+ Hits        10717    10906     +189     
+ Misses       1387     1199     -188
Flag Coverage Δ
daemon 44.46% <ø> (+0.02%) ⬆️
jina 88.53% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/base/grpc.py 70.21% <0.00%> (-14.90%) ⬇️
jina/peapods/peas/__init__.py 84.57% <0.00%> (-2.13%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 83.47% <0.00%> (-1.61%) ⬇️
jina/peapods/runtimes/zmq/zed.py 91.78% <0.00%> (-0.46%) ⬇️
jina/peapods/zmq/__init__.py 90.46% <0.00%> (+1.39%) ⬆️
jina/peapods/runtimes/container/__init__.py 82.14% <0.00%> (+1.78%) ⬆️
jina/clients/mixin.py 100.00% <0.00%> (+2.50%) ⬆️
jina/peapods/pods/__init__.py 88.88% <0.00%> (+3.62%) ⬆️
jina/flow/base.py 92.97% <0.00%> (+4.34%) ⬆️
jina/peapods/pods/k8slib/kubernetes_deployment.py 94.66% <0.00%> (+10.66%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898d157...e0847ec. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Oct 29, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1231, delta to last 2 avg.: +5%
  • 😶 query QPS at 57, delta to last 2 avg.: +2%
  • 😶 dam extend QPS at 48409, delta to last 2 avg.: +11%
  • 😶 avg flow time within 1.3715 seconds, delta to last 2 avg.: +20%
  • 😶 import jina within 0.4394 seconds, delta to last 2 avg.: +0%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1231 57 48409 1.3715 0.4394
2.1.13 1106 53 38348 1.1274 0.4488
2.1.12 1232 58 48707 1.1438 0.4264

Backed by latency-tracking. Further commits will update this comment.

@github-actions
Copy link

📝 Docs are deployed on https://docs-small-iamges-inside-big-images-tutorial--jina-docs.netlify.app 🎉

@hanxiao hanxiao merged commit 5851da8 into master Oct 29, 2021
@hanxiao hanxiao deleted the docs-small-iamges-inside-big-images-tutorial branch October 29, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/docs This issue/PR affects the docs size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tutorial: How to retrieve big-size image from small-size patch image or vice versa
2 participants
@alaeddine-13 @hanxiao
0