8000 feat: allow rolling update with uses_with in jinad by JoanFM · Pull Request #3826 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: allow rolling update with uses_with in jinad #3826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 3, 2021
Merged

feat: allow rolling update with uses_with in jinad #3826

merged 10 commits into from
Nov 3, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Oct 29, 2021

No description provided.

@JoanFM JoanFM linked an issue Oct 29, 2021 that may be closed by this pull request
make sure uses_with is properly passed to JinaD #3825
Closed
@github-actions github-actions bot added size/S area/daemon area/testing This issue/PR affects testing labels Oct 29, 2021
@JoanFM JoanFM force-pushed the handle-uses-with-in-jinad-rolling-update branch from 4c54f67 to 18eff23 Compare October 29, 2021 11:59
@codecov
Copy link
codecov bot commented Oct 29, 2021 •
edited
Loading

Codecov Report

Merging #3826 (e2058c8) into master (b58ad0a) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3826      +/-   ##
==========================================
+ Coverage   89.85%   89.94%   +0.08%     
==========================================
  Files         156      156              
  Lines       12260    12260              
==========================================
+ Hits        11016    11027      +11     
+ Misses       1244     1233      -11
Flag Coverage Δ
daemon 44.05% <100.00%> (-0.17%) ⬇️
jina 88.40% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 71.60% <100.00%> (ø)
jina/executors/decorators.py 94.54% <0.00%> (-5.46%) ⬇️
jina/jaml/parsers/executor/legacy.py 89.70% <0.00%> (-1.48%) ⬇️
jina/peapods/pods/k8s.py 81.26% <0.00%> (-1.27%) ⬇️
jina/executors/__init__.py 82.69% <0.00%> (-0.97%) ⬇️
jina/peapods/peas/__init__.py 86.70% <0.00%> (+2.12%) ⬆️
jina/peapods/pods/__init__.py 89.18% <0.00%> (+3.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9345617...e2058c8. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Oct 29, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1232, delta to last 2 avg.: -7%
  • 🐢🐢 query QPS at 58, delta to last 2 avg.: -10%
  • 🐢🐢 dam extend QPS at 48330, delta to last 2 avg.: -5%
  • 🐢🐢 avg flow time within 1.1025 seconds, delta to last 2 avg.: -11%
  • 😶 import jina within 0.4567 seconds, delta to last 2 avg.: +5%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1232 58 48330 1.1025 0.4567
2.2.3 1213 59 48023 1.4079 0.4725
2.2.2 1453 71 54079 1.0786 0.3905

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM requested review from deepankarm and jacobowitz and removed request for deepankarm October 29, 2021 18:55
@JoanFM
Copy link
Contributor Author
JoanFM commented Oct 29, 2021

@deepankarm it seems that FastAPI does not handle Dicts properly as inputs? Am I doing something wrong?

deepankarm
deepankarm suggested changes Nov 1, 2021
View reviewed changes
@JoanFM JoanFM force-pushed the handle-uses-with-in-jinad-rolling-update branch from 853aefa to 64470bf Compare November 2, 2021 07:31
@JoanFM JoanFM force-pushed the handle-uses-with-in-jinad-rolling-update branch from 64470bf to 4995d0e Compare November 2, 2021 07:33
@JoanFM JoanFM force-pushed the handle-uses-with-in-jinad-rolling-update branch from 9867db0 to 7eb85bf Compare November 2, 2021 11:57
Joan Fontanals Martinez and others added 2 commits November 2, 2021 14:51
@deepankarm deepankarm changed the title feat: allow rolling update with uses with in jinad feat: allow rolling update with uses_with in jinad Nov 2, 2021
JoanFM
JoanFM commented Nov 2, 2021
View reviewed changes
@deepankarm deepankarm force-pushed the handle-uses-with-in-jinad-rolling-update branch from 5d3be25 to 8704a5f Compare November 2, 2021 15:47
JoanFM
JoanFM commented Nov 2, 2021
View reviewed changes
@JoanFM JoanFM merged commit 2eef05d into master Nov 3, 2021
@JoanFM JoanFM deleted the handle-uses-with-in-jinad-rolling-update branch November 3, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepankarm deepankarm deepankarm approved these changes

@jacobowitz jacobowitz Awaiting requested review from jacobowitz

Assignees
No one assigned
Labels
area/daemon area/testing This issue/PR affects testing size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make sure uses_with is properly passed to JinaD
2 participants
@JoanFM @deepankarm
0