8000 fix(match): fix type of batch_size and limit in match function by hanxiao · Pull Request #3639 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(match): fix type of batch_size and limit in match function #3639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2021
Merged

fix(match): fix type of batch_size and limit in match function #3639

merged 3 commits into from
Oct 12, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Oct 11, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner October 11, 2021 20:03
@hanxiao hanxiao requested review from mapleeit and JoanFM October 11, 2021 20:03
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase component/type labels Oct 11, 2021
@github-actions
Copy link
github-actions bot commented Oct 11, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1160, delta to last 2 avg.: +2%
  • 😶 query QPS at 51, delta to last 2 avg.: +0%
  • 😶 dam extend QPS at 42828, delta to last 2 avg.: -2%
  • 😶 avg flow time within 1.6818 seconds, delta to last 2 avg.: +15%
  • 🐢🐢 import jina within 0.4534 seconds, delta to last 2 avg.: -17%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1160 51 42828 1.6818 0.4534
2.1.6 1236 55 50678 1.684 0.5015
2.1.5 1029 46 36945 1.2204 0.6

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented Oct 11, 2021 •
edited
Loading

Codecov Report

Merging #3639 (0779ba3) into master (28a6689) will increase coverage by 0.52%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3639      +/-   ##
==========================================
+ Coverage   88.97%   89.50%   +0.52%     
==========================================
  Files         154      154              
  Lines       11598    11602       +4     
==========================================
+ Hits        10319    10384      +65     
+ Misses       1279     1218      -61
Flag Coverage Δ
daemon 44.95% <0.00%> (-0.02%) ⬇️
jina 88.72% <85.71%> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/neural_ops.py 87.87% <85.71%> (-0.41%) ⬇️
jina/peapods/pods/k8slib/kubernetes_tools.py 91.91% <0.00%> (-1.02%) ⬇️
jina/peapods/zmq/__init__.py 89.51% <0.00%> (+0.69%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 85.08% <0.00%> (+0.87%) ⬆️
jina/peapods/runtimes/zmq/zed.py 94.05% <0.00%> (+0.99%) ⬆️
jina/types/message/__init__.py 87.37% <0.00%> (+1.45%) ⬆️
jina/clients/base/__init__.py 92.42% <0.00%> (+1.51%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
jina/jaml/helper.py 85.36% <0.00%> (+2.43%) ⬆️
jina/importer.py 87.17% <0.00%> (+2.56%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28a6689...0779ba3. Read the comment docs.

JoanFM
JoanFM reviewed Oct 11, 2021
View reviewed changes
Copy link
Contributor
@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will have to check tests

@github-actions github-actions bot added the area/testing This issue/PR affects testing label Oct 11, 2021
JoanFM
JoanFM suggested changes Oct 11, 2021
View reviewed changes
8000
@hanxiao hanxiao merged commit f40e63c into master Oct 12, 2021
@hanxiao hanxiao deleted the fix-batch-size-in-match branch October 12, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM requested changes

@mapleeit mapleeit Awaiting requested review from mapleeit mapleeit was automatically assigned from jina-ai/engineering

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @JoanFM
0