8000 docs: add env to docs by bwanglzu · Pull Request #3626 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: add env to docs #3626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2021
Merged

docs: add env to docs #3626

merged 2 commits into from
Oct 11, 2021

Conversation

bwanglzu
Copy link
Member

No description provided.

@github-actions github-actions bot added size/S area/doc 8000 s This issue/PR affects the docs labels Oct 11, 2021
@tadejsv
Copy link
Contributor
tadejsv commented Oct 11, 2021

But this is not really a flow feature, it's an executor feature. Passing this argument to the flow is just "syntax sugar" for passing it to all executors in the flow

@github-actions
Copy link

📝 Docs are deployed on https://docs-flow-env--jina-docs.netlify.app 🎉

@codecov
Copy link
codecov bot commented Oct 11, 2021 •
edited
Loading

Codecov Report

Merging #3626 (404d564) into master (03b4763) will increase coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3626      +/-   ##
==========================================
+ Coverage   88.41%   89.52%   +1.11%     
==========================================
  Files         154      154              
  Lines       11594    11594              
==========================================
+ Hits        10251    10380     +129     
+ Misses       1343     1214     -129
Flag Coverage Δ
daemon 44.97% <ø> (ø)
jina 88.70% <ø> (+1.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/base/grpc.py 70.21% <0.00%> (-14.90%) ⬇️
jina/peapods/pods/k8slib/kubernetes_tools.py 92.92% <0.00%> (ø)
jina/enums.py 96.17% <0.00%> (+0.54%) ⬆️
jina/peapods/peas/__init__.py 86.53% <0.00%> (+0.64%) ⬆️
jina/peapods/zmq/__init__.py 89.51% <0.00%> (+0.69%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 86.84% <0.00%> (+0.87%) ⬆️
jina/peapods/runtimes/zmq/zed.py 94.05% <0.00%> (+0.99%) ⬆️
jina/types/message/__init__.py 87.37% <0.00%> (+1.45%) ⬆️
jina/peapods/pods/k8s.py 80.25% <0.00%> (+1.68%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03b4763...404d564. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Oct 11, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1258, delta to last 2 avg.: +14%
  • 🐎🐎🐎🐎 query QPS at 56, delta to last 2 avg.: +12%
  • 🐎🐎🐎🐎 dam extend QPS at 48306, delta to last 2 avg.: +21%
  • 🐎🐎🐎🐎 avg flow time within 1.1378 seconds, delta to last 2 avg.: -22%
  • 🐢🐢 import jina within 0.4272 seconds, delta to last 2 avg.: -6%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1258 56 48306 1.1378 0.4272
2.1.6 1088 48 39334 1.2063 0.4666
2.1.5 1109 51 39874 1.7126 0.4461

Backed by latency-tracking. Further commits will update this comment.

@bwanglzu
Copy link
Member Author

@tadej-redstone agreed..so it is a bit confusing where to add, maybe have a bit more discuss needed

@JoanFM JoanFM merged commit 553b8f6 into master Oct 11, 2021
@JoanFM JoanFM deleted the docs-flow-env branch October 11, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

@alexcg1 alexcg1 Awaiting requested review from alexcg1

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/docs This issue/PR affects the docs size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwanglzu @tadejsv @JoanFM
0