8000 fix: fix reference before assignment by JoanFM · Pull Request #3615 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix reference before assignment #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2021
Merged

fix: fix reference before assignment #3615

merged 2 commits into from
Oct 9, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Oct 8, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner October 8, 2021 12:27
@JoanFM JoanFM requested review from davidbp and winstonww October 8, 2021 12:27
@JoanFM JoanFM force-pushed the fix-test-topologies branch from bd41fc4 to 5bc5974 Compare October 8, 2021 12:32
@codecov
Copy link
codecov bot commented Oct 8, 2021 •
edited
Loading

Codecov Report

Merging #3615 (58f9c4c) into master (4eb1d98) will increase coverage by 0.06%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3615      +/-   ##
==========================================
+ Coverage   89.40%   89.47%   +0.06%     
==========================================
  Files         154      154              
  Lines       11544    11552       +8     
==========================================
+ Hits        10321    10336      +15     
+ Misses       1223     1216       -7
Flag Coverage Δ
daemon 45.03% <0.00%> (-0.04%) ⬇️
jina 88.64% <64.28%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/__init__.py 87.71% <64.28%> (+0.68%) ⬆️
jina/peapods/pods/k8slib/kubernetes_tools.py 91.86% <0.00%> (ø)
jina/types/arrays/traversable.py 90.32% <0.00%> (+0.32%) ⬆️
jina/helper.py 83.12% <0.00%> (+0.35%) ⬆️
jina/peapods/pods/k8s.py 80.25% <0.00%> (+1.68%) ⬆️
jina/clients/base/http.py 98.24% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb1d98...58f9c4c. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Oct 8, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1298, delta to last 2 avg.: +0%
  • 😶 query QPS at 56, delta to last 2 avg.: -1%
  • 😶 dam extend QPS at 46788, delta to last 2 avg.: -12%
  • 😶 avg flow time within 1.6725 seconds, delta to last 2 avg.: +35%
  • 😶 import jina within 0.4013 seconds, delta to last 2 avg.: -4%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1298 56 46788 1.6725 0.4013
2.1.5 1403 62 55090 1.3452 0.4202
2.1.4 1207 51 52001 1.1159 0.4202

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Oct 8, 2021
@JoanFM JoanFM force-pushed the fix-test-topologies branch 2 times, most recently from 0fbff24 to ce7b03c Compare October 8, 2021 14:06
@JoanFM JoanFM force-pushed the fix-test-topologies branch from ce7b03c to 58f9c4c Compare October 8, 2021 14:11
jacobowitz
jacobowitz approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor
@jacobowitz jacobowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, the container reference problem in the exception was pretty annoying doing debugging, thx for fixing it

< 8000 div data-view-component="true" class="TimelineItem-body my-0">
@JoanFM JoanFM closed this Oct 9, 2021
@JoanFM JoanFM reopened this Oct 9, 2021
@JoanFM JoanFM merged commit 6d40919 into master Oct 9, 2021
@JoanFM JoanFM deleted the fix-test-topologies branch October 9, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobowitz jacobowitz jacobowitz approved these changes

@davidbp davidbp Awaiting requested review from davidbp davidbp was automatically assigned from jina-ai/engineering

@winstonww winstonww Awaiting requested review from winstonww winstonww was automatically assigned from jina-ai/engineering

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/daemon area/network This issue/PR affects network functionality component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoanFM @jacobowitz
0