8000 ci(k8s): skip k8s from success-all-test by deepankarm · Pull Request #3592 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci(k8s): skip k8s from success-all-test #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2021
Merged

ci(k8s): skip k8s from success-all-test #3592

merged 1 commit into from
Oct 6, 2021

Conversation

deepankarm
Copy link
Contributor

@JoanFM This removes k8s-test from success-all-test.needs. We'll put it back once this test is not flaky.

@deepankarm deepankarm requested a review from hanxiao as a code owner October 6, 2021 10:22
@github-actions github-actions bot added size/XS area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Oct 6, 2021
@github-actions
Copy link
github-actions bot commented Oct 6, 2021

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1219, delta to last 2 avg.: +23%
  • 😶 query QPS at 55, delta to last 2 avg.: -3%
  • 😶 dam extend QPS at 48101, delta to last 2 avg.: -8%
  • 😶 avg flow time within 1.1718 seconds, delta to last 2 avg.: -22%
  • 🐎🐎🐎🐎 import jina within 0.4254 seconds, delta to last 2 avg.: +18%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1219 55 48101 1.1718 0.4254
2.1.5 661 62 55362 1.3883 0.3456
2.1.4 1317 51 49974 1.6256 0.3696

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented Oct 6, 2021 •
edited
Loading

Codecov Report

Merging #3592 (f1cb80b) into master (3ac2603) will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3592      +/-   ##
==========================================
+ Coverage   88.19%   88.61%   +0.42%     
==========================================
  Files         154      154              
  Lines       11527    11527              
==========================================
+ Hits        10166    10215      +49     
+ Misses       1361     1312      -49
Flag Coverage Δ
daemon 45.08% <ø> (ø)
jina 88.55% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/__init__.py 88.88% <0.00%> (-0.93%) ⬇️
jina/helper.py 83.48% <0.00%> (+0.35%) ⬆️
jina/peapods/zmq/__init__.py 89.51% <0.00%> (+0.69%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.87% <0.00%> (+1.02%) ⬆️
jina/peapods/runtimes/grpc/__init__.py 87.91% <0.00%> (+1.34%) ⬆️
jina/types/message/__init__.py 87.37% <0.00%> (+1.45%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
jina/jaml/helper.py 85.36% <0.00%> (+2.43%) ⬆️
.../runtimes/request_handlers/data_request_handler.py 93.24% <0.00%> (+2.70%) ⬆️
jina/flow/base.py 86.56% <0.00%> (+2.89%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac2603...f1cb80b. Read the comment docs.

@JoanFM JoanFM merged commit 5be2d49 into master Oct 6, 2021
@JoanFM JoanFM deleted the ci-skip-k8s branch October 6, 2021 11:18
gauthamsuresh09 pushed a commit to gauthamsuresh09/jina that referenced this pull request Oct 7, 2021
@deepankarm @gauthamsuresh09
ci(k8s): skip k8s from success-all-test (jina-ai#3592)
fd038b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepankarm @JoanFM
0