8000 test: add tests proving grpc data with inspect by JoanFM · Pull Request #3595 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: add tests proving grpc data with inspect #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2021
Merged

test: add tests proving grpc data with inspect #3595

merged 2 commits into from
Oct 6, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Oct 6, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner October 6, 2021 14:13
@JoanFM JoanFM linked an issue Oct 6, 2021 that may be closed by this pull request
Kubernetes (Completion): Handle inspect pods in Kubernetes and GRPCDataRuntime #3495
Closed
@github-actions github-actions bot added size/S area/testing This issue/PR affects testing labels Oct 6, 2021
@github-actions
Copy link
github-actions bot commented Oct 6, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1207, delta to last 2 avg.: +11%
  • 🐎🐎🐎🐎 query QPS at 55, delta to last 2 avg.: +20%
  • 🐎🐎🐎🐎 dam extend QPS at 48255, delta to last 2 avg.: +24%
  • 🐎🐎🐎🐎 avg flow time within 1.6952 seconds, delta to last 2 avg.: +14%
  • 🐢🐢 import jina within 0.4119 seconds, delta to last 2 avg.: -6%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1207 55 48255 1.6952 0.4119
2.1.5 1082 47 37893 1.2119 0.4374
2.1.4 1086 43 39687 1.7615 0.4467

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented Oct 6, 2021 •
edited
Loading

Codecov Report

Merging #3595 (002b0e4) into master (3353cc8) will increase coverage by 1.21%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3595      +/-   ##
==========================================
+ Coverage   88.22%   89.43%   +1.21%     
==========================================
  Files         154      154              
  Lines       11532    11542      +10     
==========================================
+ Hits        10174    10323     +149     
+ Misses       1358     1219     -139
Flag Coverage Δ
daemon 45.07% <8.33%> (-0.04%) ⬇️
jina 88.65% <95.83%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/document.py 85.88% <95.83%> (+0.43%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 88.88% <0.00%> (-1.86%) ⬇️
jina/peapods/zmq/__init__.py 89.51% <0.00%> (+0.69%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.87% <0.00%> (+1.02%) ⬆️
jina/types/message/__init__.py 87.37% <0.00%> (+1.45%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
jina/jaml/helper.py 85.36% <0.00%> (+2.43%) ⬆️
jina/clients/mixin.py 100.00% <0.00%> (+2.50%) ⬆️
.../runtimes/request_handlers/data_request_handler.py 93.24% <0.00%> (+2.70%) ⬆️
jina/peapods/pods/__init__.py 87.21% <0.00%> (+3.40%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a6968...002b0e4. Read the comment docs.

@JoanFM JoanFM force-pushed the test-inspect-grpc-data-runtime branch from 6e74b2e to 1669637 Compare October 6, 2021 15:45
@JoanFM JoanFM merged commit add58f5 into master Oct 6, 2021
@JoanFM JoanFM deleted the test-inspect-grpc-data-runtime branch October 6, 2021 18:17
gauthamsuresh09 pushed a commit to gauthamsuresh09/jina that referenced this pull request Oct 7, 2021
@gauthamsuresh09
test: add tests proving grpc data with inspect (jina-ai#3595)
ec91814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleeit mapleeit Awaiting requested review from mapleeit mapleeit was automatically assigned from jina-ai/engineering

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang Yongxuanzhang was automatically assigned from jina-ai/engineering

@bwanglzu bwanglzu Awaiting requested review from bwanglzu

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

@jacobowitz jacobowitz Awaiting requested review from jacobowitz

Assignees
No one assigned
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes (Completion): Handle inspect pods in Kubernetes and GRPCDataRuntime
1 participant
@JoanFM
0