8000 chore: clean document array abstract class by alaeddine-13 · Pull Request #3513 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: clean document array abstract class #3513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2021
Merged

chore: clean document array abstract class #3513

merged 3 commits into from
Sep 29, 2021

Conversation

alaeddine-13
Copy link
Contributor

chore: clean document array abstract class

@alaeddine-13 alaeddine-13 requested a review from a team as a code owner September 29, 2021 08:44
@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase component/type labels Sep 29, 2021
@github-actions
Copy link
github-actions bot commented Sep 29, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1195, delta to last 2 avg.: -7%
  • 🐢🐢 query QPS at 48, delta to last 2 avg.: -10%
  • 🐢🐢 dam extend QPS at 42054, delta to last 2 avg.: -16%
  • 🐢🐢 avg flow time within 1.7116 seconds, delta to last 2 avg.: +10%
  • 😶 import jina within 0.3908 seconds, delta to last 2 avg.: +2%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1195 48 42054 1.7116 0.3908
2.1.4 1131 45 41017 1.7221 0.4182
2.1.3 1460 61 59617 1.3745 0.3444

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented Sep 29, 2021 •
edited
Loading

Codecov Report

Merging #3513 (d7e4816) into master (3a8b199) will increase coverage by 0.07%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3513      +/-   ##
==========================================
+ Coverage   89.19%   89.27%   +0.07%     
==========================================
  Files         152      152              
  Lines       11294    11291       -3     
==========================================
+ Hits        10074    10080       +6     
+ Misses       1220     1211       -9
Flag Coverage Δ
daemon 45.56% <75.00%> (-0.04%) ⬇️
jina 89.21% <91.66%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/document.py 85.20% <75.00%> (-0.19%) ⬇️
jina/types/arrays/abstract.py 65.38% <100.00%> (-3.59%) ⬇️
jina/helper.py 83.12% <0.00%> (+0.35%) ⬆️
jina/flow/base.py 90.90% <0.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91f2cbd...d7e4816. Read the comment docs.

@JoanFM JoanFM merged commit a5041be into master Sep 29, 2021
@JoanFM JoanFM deleted the chore-clean-da-dam-abstract branch September 29, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@Roshanjossey Roshanjossey Awaiting requested review from Roshanjossey

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/type size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alaeddine-13 @JoanFM @jina-bot
0