8000 ci: remove unexisting needs in cd.yml by JoanFM · Pull Request #3512 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: remove unexisting needs in cd.yml #3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2021
Merged

ci: remove unexisting needs in cd.yml #3512

merged 2 commits into from
Sep 29, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Sep 29, 2021

No description provided.

@JoanFM JoanFM requested a review from hanxiao as a code owner September 29, 2021 07:49
@github-actions github-actions bot added size/XS area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Sep 29, 2021
@JoanFM JoanFM requested a review from a team as a code owner September 29, 2021 07:51
@github-actions
Copy link
github-actions bot commented Sep 29, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1114, delta to last 2 avg.: -16%
  • 🐢🐢 query QPS at 46, delta to last 2 avg.: -18%
  • 🐢🐢 dam extend QPS at 42794, delta to last 2 avg.: -23%
  • 🐢🐢 avg flow time within 1.1736 seconds, delta to last 2 avg.: +8%
  • 🐎🐎🐎🐎 import jina within 0.4403 seconds, delta to last 2 avg.: +15%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1114 46 42794 1.1736 0.4403
2.1.4 1404 59 58861 1.0549 0.3448
2.1.3 1254 53 52402 1.1059 0.4188

Backed by latency-tracking. Further commits will update this comment.

@deepankarm deepankarm closed this Sep 29, 2021
@deepankarm deepankarm reopened this Sep 29, 2021
@deepankarm deepankarm changed the title fix: remove unexisting needs in cd ci: remove unexisting needs in cd.yml Sep 29, 2021
@github-actions github-actions bot added size/S area/cli This issue/PR affects the command line interface labels Sep 29, 2021
@codecov
Copy link
codecov bot commented Sep 29, 2021

Codecov Report

Merging #3512 (3fab8a1) into master (abd8e6c) will increase coverage by 0.40%.
The diff coverage is 93.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3512      +/-   ##
==========================================
+ Coverage   89.19%   89.59%   +0.40%     
==========================================
  Files         151      152       +1     
  Lines       11243    11262      +19     
==========================================
+ Hits        10028    10090      +62     
+ Misses       1215     1172      -43     
Flag Coverage Δ
daemon 45.71% <59.57%> (+0.20%) ⬆️
jina 89.53% <93.61%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/hubble/pull.py 100.00% <ø> (ø)
jina/parsers/hubble/push.py 94.44% <ø> (ø)
jina/peapods/pods/k8slib/kubernetes_deployment.py 95.08% <0.00%> (ø)
jina/hubble/hubapi.py 96.00% <50.00%> (-0.94%) ⬇️
jina/peapods/runtimes/container/__init__.py 80.12% <50.00%> (-1.75%) ⬇️
jina/hubble/hubio.py 88.12% <100.00%> (+0.62%) ⬆️
jina/logging/profile.py 98.19% <100.00%> (+0.01%) ⬆️
jina/parsers/hubble/__init__.py 96.87% <100.00%> (+0.72%) ⬆️
jina/parsers/hubble/new.py 100.00% <100.00%> (ø)
jina/peapods/runtimes/container/helper.py 88.09% <100.00%> (+7.32%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95bd814...3fab8a1. Read the comment docs.

@hanxiao hanxiao merged commit 82bf829 into master Sep 29, 2021
@hanxiao hanxiao deleted the fix-cd branch September 29, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/cli This issue/PR affects the command line interface area/housekeeping This issue/PR is housekeeping size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0