8000 style(cli): improve the help text remove redundant code by hanxiao · Pull Request #3519 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

style(cli): improve the help text remove redundant code #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2021
Merged

style(cli): improve the help text remove redundant code #3519

merged 3 commits into from
Sep 29, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Sep 29, 2021

No description provided.

@hanxiao hanxiao requested review from alexcg1 and a team as code owners September 29, 2021 13:58
@hanxiao hanxiao requested a review from makram93 September 29, 2021 13:58
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs labels Sep 29, 2021
@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1433, delta to last 2 avg.: +32%
  • 🐎🐎🐎🐎 query QPS at 61, delta to last 2 avg.: +40%
  • 🐎🐎🐎🐎 dam extend QPS at 58482, delta to last 2 avg.: +52%
  • 🐎🐎🐎🐎 avg flow time within 1.0846 seconds, delta to last 2 avg.: -32%
  • 🐢🐢 import jina within 0.3485 seconds, delta to last 2 avg.: -20%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1433 61 58482 1.0846 0.3485
2.1.4 1026 42 36638 1.4781 0.4352
2.1.3 1130 44 40230 1.7183 0.4361

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit e605109 into master Sep 29, 2021
@hanxiao hanxiao deleted the style-hub-new-cli branch September 29, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcg1 alexcg1 Awaiting requested review from alexcg1

@makram93 makram93 Awaiting requested review from makram93

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanxiao
0