8000 fix: fix skip code injection by JoanFM · Pull Request #3497 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix skip code injection #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2021
Merged

fix: fix skip code injection #3497

merged 1 commit into from
Sep 28, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Sep 28, 2021

No description provided.

@JoanFM JoanFM requested a review from hanxiao as a code owner September 28, 2021 08:17
@github-actions github-actions bot added size/XS area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Sep 28, 2021
@github-actions
Copy link
github-actions bot commented Sep 28, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1096, delta to last 2 avg.: -18%
  • 🐢🐢 query QPS at 44, delta to last 2 avg.: -18%
  • 🐢🐢 dam extend QPS at 40567, delta to last 2 avg.: -24%
  • 🐢🐢 avg flow time within 1.4812 seconds, delta to last 2 avg.: +6%
  • 🐎🐎🐎🐎 import jina within 0.4378 seconds, delta to last 2 avg.: +22%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1096 44 40567 1.4812 0.4378
2.1.4 1479 61 62752 1.086 0.3342
2.1.3 1195 46 44426 1.7028 0.3788

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented Sep 28, 2021 •
edited
Loading

Codecov Report

Merging #3497 (421f18f) into master (abd8e6c) will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3497      +/-   ##
==========================================
+ Coverage   89.19%   89.53%   +0.33%     
==========================================
  Files         151      151              
  Lines       11243    11243              
==========================================
+ Hits        10028    10066      +38     
+ Misses       1215     1177      -38
Flag Coverage Δ
daemon 45.50% <ø> (ø)
jina 89.46% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/base/grpc.py 63.82% <0.00%> (-6.39%) ⬇️
jina/peapods/runtimes/gateway/prefetch.py 93.82% <0.00%> (-1.24%) ⬇️
jina/peapods/zmq/__init__.py 89.51% <0.00%> (+0.23%) ⬆️
jina/peapods/runtimes/gateway/http/app.py 92.40% <0.00%> (+1.26%) ⬆️
jina/flow/base.py 89.77% <0.00%> (+1.53%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 90.74% <0.00%> (+1.85%) ⬆️
jina/clients/base/http.py 97.77% <0.00%> (+2.22%) ⬆️
jina/peapods/runtimes/zmq/asyncio.py 90.32% <0.00%> (+3.22%) ⬆️
jina/types/routing/table.py 94.06% <0.00%> (+3.38%) ⬆️
jina/peapods/grpc/__init__.py 90.00% <0.00%> (+4.44%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd8e6c...421f18f. Read the comment docs.

@ghost ghost mentioned this pull request Sep 28, 2021
Closed
jacobowitz
jacobowitz approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor
@jacobowitz jacobowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, verified by #3499

@hanxiao hanxiao merged commit a1faf8f into master Sep 28, 2021
@hanxiao hanxiao deleted the fix-skip-injection branch September 28, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobowitz jacobowitz jacobowitz approved these changes

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @jacobowitz @hanxiao
0