8000 refactor: RAII for pods by JoanFM · Pull Request #3474 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: RAII for pods #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 29, 2021
Merged

refactor: RAII for pods #3474

merged 6 commits into from
Sep 29, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Sep 24, 2021 •
edited
Loading

Changes introduced

  • Whenever a Pod is initialized, all its internal components must be initialized, and then entering context is delegated at start time.

This is needed to refactor in a nice manner the plotting of Plots #3445

@JoanFM JoanFM requested a review from a team as a code owner September 24, 2021 10:16
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Sep 24, 2021
@JoanFM
Copy link
Contributor Author
JoanFM commented Sep 24, 2021

Will most likely not work for deepcopy in Flow

@codecov
Copy link
codecov bot commented Sep 24, 2021 •
edited
Loading

Codecov Report

Merging #3474 (094e217) into master (abd8e6c) will increase coverage by 0.38%.
The diff coverage is 95.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3474      +/-   ##
==========================================
+ Coverage   89.19%   89.57%   +0.38%     
==========================================
  Files         151      152       +1     
  Lines       11243    11262      +19     
==========================================
+ Hits        10028    10088      +60     
+ Misses       1215     1174      -41
Flag Coverage Δ
daemon 45.71% <65.67%> (+0.20%) ⬆️
jina 89.51% <95.52%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/hubble/pull.py 100.00% <ø> (ø)
jina/parsers/hubble/push.py 94.44% <ø> (ø)
jina/peapods/pods/k8slib/kubernetes_deployment.py 95.08% <0.00%> (ø)
jina/hubble/hubapi.py 96.00% <50.00%> (-0.94%) ⬇️
jina/peapods/runtimes/container/__init__.py 80.12% <50.00%> (-1.75%) ⬇️
jina/flow/base.py 90.06% <100.00%> (+1.82%) ⬆️
jina/hubble/hubio.py 88.12% <100.00%> (+0.62%) ⬆️
jina/logging/profile.py 98.19% <100.00%> (+0.01%) ⬆️
jina/parsers/hubble/__init__.py 96.87% <100.00%> (+0.72%) ⬆️
jina/parsers/hubble/new.py 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f5ee8e...094e217. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Sep 24, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1279, delta to last 2 avg.: -5%
  • 😶 query QPS at 53, delta to last 2 avg.: -4%
  • 😶 dam extend QPS at 53425, delta to last 2 avg.: -1%
  • 😶 avg flow time within 1.126 seconds, delta to last 2 avg.: +0%
  • 😶 import jina within 0.3921 seconds, delta to last 2 avg.: +1%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1279 53 53425 1.126 0.3921
2.1.4 1528 61 58860 1.0819 0.3454
2.1.3 1188 48 49701 1.1737 0.4304

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM force-pushed the pods-raii branch 2 times, most recently from 938d141 to e5c344e Compare September 24, 2021 12:30
@JoanFM JoanFM closed this Sep 24, 2021
@JoanFM JoanFM reopened this Sep 24, 2021
@JoanFM JoanFM force-pushed the pods-raii branch 3 times, most recently from 24ee93f to 5dd70cf Compare September 24, 2021 20:15
@JoanFM JoanFM added the focus/ease-of-use This issue/PR affects the usability of the core label Sep 27, 2021
jacobowitz
jacobowitz previously approved these changes Sep 27, 2021
View reviewed changes
@deepankarm deepankarm closed this Sep 29, 2021
@deepankarm deepankarm reopened this Sep 29, 2021
@github-actions github-actions bot added the area/cli This issue/PR affects the command line interface label Sep 29, 2021
@github-actions github-actions bot removed the area/cli This issue/PR affects the command line interface label Sep 29, 2021
@jacobowitz jacobowitz closed this Sep 29, 2021
@jacobowitz jacobowitz reopened this Sep 29, 2021
@github-actions github-actions bot added the area/cli This issue/PR affects the command line interface label Sep 29, 2021
@JoanFM JoanFM merged commit ad78e88 into master Sep 29, 2021
@JoanFM JoanFM deleted the pods-raii branch September 29, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepankarm deepankarm deepankarm approved these changes

@jacobowitz jacobowitz jacobowitz left review comments

@Roshanjossey Roshanjossey Awaiting requested review from Roshanjossey

@alaeddine-13 alaeddine-13 Awaiting requested review from alaeddine-13

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/daemon area/network This issue/PR affects network functionality component/flow component/peapod focus/ease-of-use This issue/PR affects the usability of the core size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoanFM @jacobowitz @deepankarm @jina-bot
0