8000 feat(types): DocumentArray supports save and load with csv by hanxiao · Pull Request #3460 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(types): DocumentArray supports save and load with csv #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2021
Merged

feat(types): DocumentArray supports save and load with csv #3460

merged 1 commit into from
Sep 22, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Sep 22, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner September 22, 2021 20:39
@hanxiao hanxiao requested review from mapleeit and numb3r3 September 22, 2021 20:39
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Sep 22, 2021
@github-actions
Copy link
github-actions bot commented Sep 22, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐎🐎 index QPS at 1466, delta to last 2 avg.: +7%
  • 🐎🐎 query QPS at 60, delta to last 2 avg.: +6%
  • 🐎🐎 dam extend QPS at 60360, delta to last 2 avg.: +21%
  • 🐎🐎 avg flow time within 1.081 seconds, delta to last 2 avg.: -21%
  • 😶 import jina within 0.3404 seconds, delta to last 2 avg.: -4%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1466 60 60360 1.081 0.3404
2.1.2 1479 60 56860 1.0565 0.3303
2.1.1 1252 51 42726 1.696 0.3821

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented Sep 22, 2021 •
edited
Loading

Codecov Report

Merging #3460 (5839694) into master (c1e6d9a) will decrease coverage by 0.06%.
The diff coverage is 55.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3460      +/-   ##
==========================================
- Coverage   90.27%   90.21%   -0.07%     
==========================================
  Files         151      151              
  Lines       10977    11009      +32     
==========================================
+ Hits         9910     9932      +22     
- Misses       1067     1077      +10
Flag Coverage Δ
daemon 45.72% <11.76%> (-0.10%) ⬇️
jina 90.20% <55.88%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/document.py 85.38% <55.88%> (-3.0 996A 2%) ⬇️
jina/clients/base/__init__.py 92.42% <0.00%> (+1.51%) ⬆️
jina/importer.py 87.17% <0.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e6d9a...5839694. Read the comment docs.

@hanxiao hanxiao merged commit f5f1a77 into master Sep 22, 2021
@hanxiao hanxiao deleted the feat-da-to-csv branch September 22, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleeit mapleeit Awaiting requested review from mapleeit

@numb3r3 numb3r3 Awaiting requested review from numb3r3

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanxiao
0