8000 fix: batching for multi-valued blobs and embeddings by tadejsv · Pull Request #3451 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

fix: batching for multi-valued blobs and embeddings #3451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2021
Merged

fix: batching for multi-valued blobs and embeddings #3451

merged 1 commit into from
Sep 21, 2021

Conversation

tadejsv
Copy link
Contributor
@tadejsv tadejsv commented Sep 21, 2021

Closes #3450

@tadejsv tadejsv requested a review from a team as a code owner September 21, 2021 08:00
@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Sep 21, 2021
maximilianwerk
maximilianwerk approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member
@maximilianwerk maximilianwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
codecov bot commented Sep 21, 2021 •
edited
Loading

Codecov Report

Merging #3451 (38e5881) into master (cb46192) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3451      +/-   ##
==========================================
- Coverage   90.28%   89.75%   -0.54%     
==========================================
  Files         152      152              
  Lines       11019    11022       +3     
==========================================
- Hits         9949     9893      -56     
- Misses       1070     1129      +59
Flag Coverage Δ
daemon 45.60% <0.00%> (-0.02%) ⬇️
jina 89.32% <100.00%> (-0.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/traversable.py 90.00% <100.00%> (+0.52%) ⬆️
jina/flow/base.py 82.01% <0.00%> (-7.94%) ⬇️
jina/jaml/parsers/__init__.py 92.85% <0.00%> (-7.15%) ⬇️
.../runtimes/request_handlers/data_request_handler.py 90.54% <0.00%> (-2.71%) ⬇️
jina/jaml/helper.py 82.92% <0.00%> (-2.44%) ⬇️
jina/jaml/parsers/flow/v1.py 96.49% <0.00%> (-1.76%) ⬇️
jina/types/message/__init__.py 85.92% <0.00%> (-1.46%) ⬇️
jina/peapods/runtimes/zmq/zed.py 92.85% <0.00%> (-1.03%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 90.47% <0.00%> (-0.96%) ⬇️
jina/peapods/zmq/__init__.py 88.81% <0.00%> (-0.70%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 907cf8e...38e5881. Read the comment docs.

@tadejsv tadejsv merged commit 951ffc4 into master Sep 21, 2021
@tadejsv tadejsv deleted the fix-batching branch September 21, 2021 08:40
@tadejsv tadejsv mentioned this pull request Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilianwerk maximilianwerk maximilianwerk approved these changes

@JoanFM JoanFM JoanFM approved these changes

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

require_attr in DocumentArray.batch does not work for blob
3 participants
@tadejsv @maximilianwerk @JoanFM
0