8000 fix(types): .match fn exclude_self should maintain num results by hanxiao · Pull Request #3458 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(types): .match fn exclude_self should maintain num results #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2021
Merged

fix(types): .match fn exclude_self should maintain num results #3458

merged 2 commits into from
Sep 22, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Sep 22, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner September 22, 2021 08:10
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Sep 22, 2021
@codecov
Copy link
codecov bot commented Sep 22, 2021 •
edited
Loading

Codecov Report

Merging #3458 (aa01cf0) into master (b8f2641) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3458      +/-   ##
==========================================
- Coverage   90.32%   90.27%   -0.06%     
==========================================
  Files         152      151       -1     
  Lines       11023    10977      -46     
==========================================
- Hits         9957     9909      -48     
- Misses       1066     1068       +2
Flag Coverage Δ
daemon 45.82% <0.00%> (+0.20%) ⬆️
jina 90.26% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/neural_ops.py 89.25% <100.00%> (ø)
jina/clients/base/grpc.py 63.82% <0.00%> (-6.39%) ⬇️
jina/peapods/runtimes/gateway/prefetch.py 93.82% <0.00%> (-1.24%) ⬇️
jina/types/document/multimodal.py
jina/types/arrays/memmap.py 95.25% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c97d99f...aa01cf0. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Sep 22, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1270, delta to last 2 avg.: -9%
  • 🐢🐢 query QPS at 52, delta to last 2 avg.: -11%
  • 🐢🐢 dam extend QPS at 53517, delta to last 2 avg.: -7%
  • 🐢🐢 avg flow time within 1.6351 seconds, delta to last 2 avg.: +36%
  • 🐎🐎🐎🐎 import jina within 0.4076 seconds, delta to last 2 avg.: +13%

Breakdown

9CC7
Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1270 52 53517 1.6351 0.4076
2.1.2 1459 61 59582 1.3056 0.3325
2.1.1 1340 56 55961 1.0919 0.3829

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 3f35d3f into master Sep 22, 2021
@hanxiao hanxiao deleted the fix-exclude-self-limit branch September 22, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imsergiy imsergiy Awaiting requested review from imsergiy

@deepankarm deepankarm Awaiting requested review from deepankarm

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanxiao
0