8000 feat: new image force by alaeddine-13 · Pull Request #3441 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: new image force #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 20, 2021
Merged

feat: new image force #3441

merged 5 commits into from
Sep 20, 2021

Conversation

alaeddine-13
Copy link
Contributor

feat: get fetch metas only when using --force, otherwise, default to local cache

@alaeddine-13 alaeddine-13 requested a review from a team as a code owner September 20, 2021 08:54
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Sep 20, 2021
@codecov
Copy link
codecov bot commented Sep 20, 2021 •
edited
Loading

Codecov Report

Merging #3441 (c7de2c8) into master (b25945e) will increase coverage by 0.70%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3441      +/-   ##
==========================================
+ Coverage   89.68%   90.39%   +0.70%     
==========================================
  Files         152      152              
  Lines       10967    10969       +2     
==========================================
+ Hits         9836     9915      +79     
+ Misses       1131     1054      -77
Flag Coverage Δ
daemon 45.61% <0.00%> (-0.01%) ⬇️
jina 90.38% <100.00%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/hubble/helper.py 90.19% <100.00%> (+0.12%) ⬆️
jina/hubble/hubio.py 87.77% <100.00%> (+1.56%) ⬆️
jina/types/document/__init__.py 96.07% <0.00%> (+0.78%) ⬆️
jina/peapods/runtimes/gateway/prefetch.py 95.06% <0.00%> (+1.23%) ⬆️
jina/helper.py 83.33% <0.00%> (+1.44%) ⬆️
jina/peapods/runtimes/container/__init__.py 83.51% <0.00%> (+1.64%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 93.33% <0.00%> (+1.90%) ⬆️
jina/peapods/runtimes/gateway/http/app.py 92.40% <0.00%> (+2.53%) ⬆️
jina/importer.py 87.17% <0.00%> (+2.56%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 964e717...c7de2c8. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Sep 20, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1239, delta to last 2 avg.: +5%
  • 😶 query QPS at 47, delta to last 2 avg.: +0%
  • 😶 dam extend QPS at 51623, delta to last 2 avg.: +18%
  • 😶 avg flow time within 1.1066 seconds, delta to last 2 avg.: -36%
  • 😶 import jina within 0.4081 seconds, delta to last 2 avg.: -4%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1239 47 51623 1.1066 0.4081
2.1.1 1117 45 40480 1.7067 0.4158
2.1.0 1220 49 46539 1.768 0.4411

Backed by latency-tracking. Further commits will update this comment.

@alaeddine-13 alaeddine-13 linked an issue Sep 20, 2021 that may be closed by this pull request
make fetch_metas default to cache if force=False #3443
Closed
@alaeddine-13 alaeddine-13 merged commit c9f2e65 into master Sep 20, 2021
@alaeddine-13 alaeddine-13 deleted the feat-new-image-force branch September 20, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianmtr cristianmtr cristianmtr approved these changes

@mapleeit mapleeit Awaiting requested review from mapleeit

@numb3r3 numb3r3 Awaiting requested review from numb3r3

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make fetch_metas default to cache if force=False
2 participants
@alaeddine-13 @cristianmtr
0