8000 feat: k8s custom port expose by florian-hoenicke · Pull Request #3449 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: k8s custom port expose #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 21, 2021
Merged

feat: k8s custom port expose #3449

merged 6 commits into from
Sep 21, 2021

Conversation

florian-hoenicke
Copy link
Member

Currently, the only possible port to reach the k8s gateway is 8080.
This pr makes it possible to specify the port number in the flow

@florian-hoenicke florian-hoenicke requested a review from a team as a code owner September 20, 2021 20:30
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod labels Sep 20, 2021
JoanFM
JoanFM suggested changes Sep 20, 2021
View reviewed changes
JoanFM
JoanFM suggested changes Sep 20, 2021
View reviewed changes
@github-actions
Copy link
github-actions bot commented Sep 20, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1080, delta to last 2 avg.: -18%
  • 🐢🐢 query QPS at 44, delta to last 2 avg.: -20%
  • 🐢🐢 dam extend QPS at 37900, delta to last 2 avg.: -28%
  • 🐢🐢 avg flow time within 1.1705 seconds, delta to last 2 avg.: -14%
  • 🐎🐎🐎🐎 import jina within 0.4443 seconds, delta to last 2 avg.: +19%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1080 44 37900 1.1705 0.4443
2.1.2 1461< 8000 /td> 62 60610 1.0738 0.3403
2.1.1 1185 48 44749 1.6738 0.4029

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added size/M area/cli This issue/PR affects the command line interface component/flow labels Sep 21, 2021
@codecov
Copy link
codecov bot commented Sep 21, 2021 •
edited
Loading

Codecov Report

Merging #3449 (4997f51) into master (4a5eee9) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3449      +/-   ##
==========================================
+ Coverage   90.43%   90.52%   +0.09%     
==========================================
  Files         152      152              
  Lines       11009    11020      +11     
==========================================
+ Hits         9956     9976      +20     
+ Misses       1053     1044       -9
Flag Coverage Δ
daemon 45.62% <60.00%> (-0.01%) ⬇️
jina 90.51% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/flow/base.py 89.96% <ø> (+0.01%) ⬆️
jina/peapods/pods/k8s.py 92.00% <ø> (ø)
jina/parsers/__init__.py 97.89% <100.00%> (ø)
jina/peapods/pods/k8slib/kubernetes_deployment.py 94.82% <100.00%> (ø)
jina/clients/__init__.py 90.90% <0.00%> (-9.10%) ⬇️
jina/peapods/peas/__init__.py 85.89% <0.00%> (-4.49%) ⬇️
jina/peapods/pods/compound.py 90.34% <0.00%> (-1.38%) ⬇️
jina/peapods/runtimes/zmq/zed.py 93.87% <0.00%> (-0.52%) ⬇️
jina/parsers/peapods/runtimes/remote.py 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a5eee9...4997f51. Read the comment docs.

@florian-hoenicke florian-hoenicke merged commit b8f2641 into master Sep 21, 2021
@florian-hoenicke florian-hoenicke deleted the feat-k8s-custom-port-expose branch September 21, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

@nan-wang nan-wang Awaiting requested review from nan-wang

@jacobowitz jacobowitz Awaiting requested review from jacobowitz

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/flow component/peapod size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florian-hoenicke @JoanFM @jina-bot
0