8000 fix(hubio): only print single usage at a time by hanxiao · Pull Request #3430 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(hubio): only print single usage at a time #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2021
Merged

fix(hubio): only print single usage at a time #3430

merged 2 commits into from
Sep 17, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Sep 17, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner September 17, 2021 07:28
@hanxiao hanxiao requested review f 8000 rom nan-wang and jacobowitz September 17, 2021 07:28
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Sep 17, 2021
@codecov
Copy link
codecov bot commented Sep 17, 2021 •
edited
Loading

Codecov Report

Merging #3430 (c30392d) into master (785d8f9) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3430      +/-   ##
==========================================
+ Coverage   89.91%   90.12%   +0.20%     
==========================================
  Files         152      152              
  Lines       10910    10925      +15     
==========================================
+ Hits         9810     9846      +36     
+ Misses       1100     1079      -21
Flag Coverage Δ
daemon 45.68% <9.09%> (-0.04%) ⬇️
jina 90.11% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/hubble/hubio.py 86.20% <100.00%> (+0.35%) ⬆️
jina/importer.py 84.61% <0.00%> (-2.57%) ⬇️
jina/peapods/pods/k8slib/kubernetes_tools.py 79.71% <0.00%> (-1.54%) ⬇️
jina/clients/base/__init__.py 90.90% <0.00%> (-1.52%) ⬇️
jina/helper.py 82.97% <0.00%> (-0.37%) ⬇️
jina/flow/base.py 88.18% <0.00%> (-0.18%) ⬇️
jina/peapods/pods/k8slib/kubernetes_deployment.py 94.82% <0.00%> (ø)
jina/peapods/pods/k8s.py 92.00% <0.00%> (+0.13%) ⬆️
jina/peapods/zmq/__init__.py 89.04% <0.00%> (+0.23%) ⬆️
jina/peapods/runtimes/gateway/http/app.py 92.40% <0.00%> (+1.26%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ab063...c30392d. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Sep 17, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1077, delta to last 2 avg.: -8%
  • 🐢🐢 query QPS at 44, delta to last 2 avg.: -11%
  • 🐢🐢 dam extend QPS at 38538, delta to last 2 avg.: -17%
  • 🐢🐢 avg flow time within 1.4607 seconds, delta to last 2 avg.: +0%
  • 😶 import jina within 0.4433 seconds, delta to last 2 avg.: -5%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1077 44 38538 1.4607 0.4433
2.1.0 1114 46 40046 1.4851 0.4759
2.0.24 1252 53 53468 1.4535 0.4621

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao marked this pull request as draft September 17, 2021 08:02
@hanxiao hanxiao marked this pull request as ready for review September 17, 2021 11:42
@hanxiao hanxiao merged commit 11916dc into master Sep 17, 2021
@hanxiao hanxiao deleted the fix-only-print-one-usage branch September 17, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleeit mapleeit mapleeit approved these changes

@nan-wang nan-wang Awaiting requested review from nan-wang

@jacobowitz jacobowitz Awaiting requested review from jacobowitz

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @mapleeit
0