8000 feat(helper): progressbar now has a spinner by hanxiao · Pull Request #3434 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(helper): progressbar now has a spinner #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2021
Merged

feat(helper): progressbar now has a spinner #3434

merged 1 commit into from
Sep 18, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Sep 18, 2021

built-in progress bar now has a spinner thread to show long halting progress

57ec9017dc52bbb1711041d4671dda71

@hanxiao hanxiao requested a review from a team as a code owner September 18, 2021 10:13
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase component/logging labels Sep 18, 2021
@codecov
Copy link
codecov bot commented Sep 18, 2021 •
edited
Loading

Codecov Report

Merging #3434 (4e14a05) into master (bc35b41) will decrease coverage by 0.52%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3434      +/-   ##
==========================================
- Coverage   90.21%   89.69%   -0.53%     
==========================================
  Files         152      152              
  Lines       10936    10956      +20     
==========================================
- Hits         9866     9827      -39     
- Misses       1070     1129      +59
Flag Coverage Δ
daemon 45.64% <28.00%> (-0.03%) ⬇️
jina 89.25% <84.00%> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/logging/profile.py 96.00% <83.33%> (-2.47%) ⬇️
jina/__init__.py 70.88% <100.00%> (ø)
jina/flow/base.py 82.01% <0.00%> (-7.94%) ⬇️
jina/jaml/parsers/__init__.py 92.85% <0.00%> (-7.15%) ⬇️
jina/peapods/runtimes/gateway/http/__init__.py 97.14% <0.00%> (-2.86%) ⬇️
.../runtimes/request_handlers/data_request_handler.py 90.54% <0.00%> (-2.71%) ⬇️
jina/jaml/helper.py 82.92% <0.00%> (-2.44%) ⬇️
jina/jaml/parsers/flow/v1.py 96.49% <0.00%> (-1.76%) ⬇️
jina/types/message/__init__.py 85.92% <0.00%> (-1.46%) ⬇️
jina/peapods/runtimes/zmq/zed.py 92.85% <0.00%> (-1.03%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 569ccaf...4e14a05. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1462, delta to last 2 avg.: +25%
  • 🐎🐎🐎🐎 query QPS at 55, delta to last 2 avg.: +11%
  • 🐎🐎🐎🐎 dam extend QPS at 61316, delta to last 2 avg.: +42%
  • 🐎🐎🐎🐎 avg flow time within 1.1004 seconds, delta to last 2 avg.: -30%
  • 🐢🐢 import jina within 0.3318 seconds, delta to last 2 avg.: -27%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1462 55 61316 1.1004 0.3318
2.1.1 1122 46 40527 1.7135 0.4453
2.1.0 1206 52 45809 1.443 0.4731

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 9de1993 into master Sep 18, 2021
@hanxiao hanxiao deleted the feat-pbar-thread branch September 18, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/logging size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanxiao
0