8000 fix(hubio): make hub pulling progressbar smoother by hanxiao · Pull Request #3414 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(hubio): make hub pulling progressbar smoother #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2021
Merged

fix(hubio): make hub pulling progressbar smoother #3414

merged 3 commits into from
Sep 15, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Sep 15, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner September 15, 2021 11:04
@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase labels Sep 15, 2021
@codecov
Copy link
codecov bot commented Sep 15, 2021 •
edited
Loading

Codecov Report

Merging #3414 (9ce5d20) into master (6004d57) will increase coverage by 0.94%.
The diff coverage is 88.57%.

❗ Current head 9ce5d20 differs from pull request most recent head 5117619. Consider uploading reports for the commit 5117619 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3414      +/-   ##
==========================================
+ Coverage   89.36%   90.31%   +0.94%     
==========================================
  Files         152      152              
  Lines       10902    10906       +4     
==========================================
+ Hits         9743     9850     +107     
+ Misses       1159     1056     -103
Flag Coverage Δ
daemon 45.70% <0.00%> (-0.02%) ⬇️
jina 90.30% <88.57%> (+1.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/hubble/hubio.py 88.66% <88.57%> (-0.19%) ⬇️
jina/helper.py 82.97% <0.00%> (-0.37%) ⬇️
jina/peapods/zmq/__init__.py 89.04% <0.00%> (+0.93%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 93.33% <0.00%> (+0.95%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.87% <0.00%> (+1.02%) ⬆️
jina/peapods/runtimes/gateway/http/app.py 92.40% <0.00%> (+1.26%) ⬆️
jina/types/message/__init__.py 87.37% <0.00%> (+1.45%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
jina/peapods/runtimes/zmq/asyncio.py 92.98% <0.00%> (+1.75%) ⬆️
jina/jaml/helper.py 85.36% <0.00%> (+2.43%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6004d57...5117619. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Sep 15, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1193, delta to last 2 avg.: -8%
  • 🐢🐢 query QPS at 49, delta to last 2 avg.: -9%
  • 🐢🐢 dam extend QPS at 42523, delta to last 2 avg.: -16%
  • 🐢🐢 avg flow time within 1.6872 seconds, delta to last 2 avg.: +43%
  • 🐢🐢 import jina within 0.3943 seconds, delta to last 2 avg.: -12%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1193 49 42523 1.6872 0.3943
2.1.0 1092 45 40992 1.2347 0.517
2.0.24 1502 62 61084 1.1206 0.3791

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit df462df into master Sep 15, 2021
@hanxiao hanxiao deleted the fix-hub-pulling-exp branch September 15, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang Awaiting requested review from nan-wang

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanxiao
0