8000 feat(types): allow match on traversal paths by hanxiao · Pull Request #3405 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(types): allow match on traversal paths #3405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2021
Merged

feat(types): allow match on traversal paths #3405

merged 2 commits into from
Sep 14, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Sep 14, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner September 14, 2021 12:04
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Sep 14, 2021
@codecov
Copy link
codecov bot commented Sep 14, 2021 •
edited
Loading

Codecov Report

Merging #3405 (a33f029) into master (d37e6ab) will increase coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3405      +/-   ##
==========================================
+ Coverage   89.71%   90.24%   +0.53%     
==========================================
  Files         152      152              
  Lines       10840    10861      +21     
==========================================
+ Hits         9725     9802      +77     
+ Misses       1115     1059      -56
Flag Coverage Δ
daemon 45.54% <5.55%> (-0.03%) ⬇️
jina 90.24% <100.00%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/neural_ops.py 89.91% <100.00%> (+0.92%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 91.42% <0.00%> (-1.91%) ⬇️
jina/hubble/hubio.py 88.85% <0.00%> (+0.03%) ⬆️
jina/flow/base.py 89.16% <0.00%> (+0.08%) ⬆️
jina/jaml/__init__.py 95.51% <0.00%> (+0.12%) ⬆️
jina/types/document/__init__.py 96.07% <0.00%> (+0.78%) ⬆️
jina/helper.py 82.97% <0.00%> (+1.44%) ⬆️
jina/peapods/runtimes/gateway/http/app.py 92.40% <0.00%> (+2.53%) ⬆️
jina/clients/request/__init__.py 100.00% <0.00%> (+5.00%) ⬆️
jina/clients/request/helper.py 83.92% <0.00%> (+5.35%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d47c0...a33f029. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1068, delta to last 2 avg.: -9%
  • 🐢🐢 query QPS at 43, delta to last 2 avg.: -13%
  • 🐢🐢 dam extend QPS at 38945, delta to last 2 avg.: -14%
  • 🐢🐢 avg flow time within 1.774 seconds, delta to last 2 avg.: +43%
  • 🐎🐎🐎🐎 import jina within 0.5602 seconds, delta to last 2 avg.: +17%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1068 43 38945 1.774 0.5602
2.1.0 1116 45 39231 1.2411 0.4805
2.0.24 1236 53 51630 1.2322 0.4699

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added size/M and removed size/S labels Sep 14, 2021
@hanxiao hanxiao merged commit fbd0ec2 into master Sep 14, 2021
@hanxiao hanxiao deleted the feat-match-along-traversal branch September 14, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

@maateen maateen Awaiting requested review from maateen

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanxiao
0