8000 fix(executor): improve checking for executor init and @requests func by hanxiao · Pull Request #3391 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(executor): improve checking for executor init and @requests func #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 12, 2021
Merged

fix(executor): improve checking for executor init and @requests func #3391

merged 6 commits into from
Sep 12, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Sep 12, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner September 12, 2021 08:01
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/executor component/jaml executor/meta labels Sep 12, 2021
@github-actions
Copy link
github-actions bot commented Sep 12, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐎🐎 index QPS at 1173, delta to last 2 avg.: +9%
  • 🐎🐎 query QPS at 47, delta to last 2 avg.: +8%
  • 🐎🐎 dam extend QPS at 40396, delta to last 2 avg.: +0%
  • 🐎🐎 avg flow time within 1.4983 seconds, delta to last 2 avg.: +0%
  • 🐎🐎 import jina within 0.487 seconds, delta to last 2 avg.: +6%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1173 47 40396 1.4983 0.487
2.0.24 1111 45 40700 1.7603 0.4765
2.0.23 1030 41 39827 1.2645 0.4357

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao closed this Sep 12, 2021
@hanxiao hanxiao reopened this Sep 12, 2021
@codecov
Copy link
codecov bot commented Sep 12, 2021 •
edited
Loading

Codecov Report

Merging #3391 (22be23a) into master (7a3f706) will increase coverage by 0.02%.
The diff coverage is 91.66%.

❗ Current head 22be23a differs from pull request most recent head 46d7acc. Consider uploading reports for the commit 46d7acc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3391      +/-   ##
==========================================
+ Coverage   90.22%   90.24%   +0.02%     
==========================================
  Files         152      152              
  Lines       10852    10857       +5     
==========================================
+ Hits         9791     9798       +7     
+ Misses       1061     1059       -2
Flag Coverage Δ
daemon 45.48% <83.33%> (+0.01%) ⬆️
jina 90.23% <91.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/__init__.py 100.00% <ø> (ø)
jina/flow/base.py 89.08% <ø> (ø)
jina/jaml/parsers/executor/legacy.py 89.70% <ø> (ø)
jina/types/document/__init__.py 96.07% <ø> (ø)
jina/executors/__init__.py 83.49% <85.71%> (+0.66%) ⬆️
jina/__init__.py 70.88% <100.00%> (+0.37%) ⬆️
jina/executors/decorators.py 100.00% <100.00%> (ø)
jina/helper.py 83.33% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f0ded...46d7acc. Read the comment docs.

@hanxiao hanxiao requested a review from alexcg1 as a code owner September 12, 2021 09:06
@github-actions github-actions bot added size/L area/docs This issue/PR affects the docs and removed size/M labels Sep 12, 2021
@hanxiao hanxiao merged commit 59b67fa into master Sep 12, 2021
@hanxiao hanxiao deleted the fix-executor-args-check branch September 12, 2021 10:29
deepankarm pushed a commit that referenced this pull request Sep 14, 2021
@hanxiao @jina-bot @deepankarm
fix(executor): improve checking for executor init and @requests func (#…
feea5cb 
…3391)

* fix(executor): improve checking for executor init and @requests func

* fix(executor): improve checking for executor init and @requests func

* style: fix overload and cli autocomplete

* fix(executor): improve checking for executor init and @requests func

* docs(executor): restructure executor chapter

Co-authored-by: Jina Dev Bot <dev-bot@jina.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatStark CatStark Awaiting requested review from CatStark

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

@alexcg1 alexcg1 Awaiting requested review from alexcg1

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/client component/executor component/flow component/jaml component/type executor/meta size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0