8000 fix(type): empty DA match should be just nop by hanxiao · Pull Request #3385 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(type): empty DA match should be just nop #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2021
Merged

fix(type): empty DA match should be just nop #3385

merged 1 commit into from
Sep 10, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Sep 10, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner September 10, 2021 15:39
@hanxiao hanxiao requested review from JoanFM and slettner September 10, 2021 15:39
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Sep 10, 2021
@hanxiao hanxiao changed the title fix: empty DA match should be just nop fix(type): empty DA match should be just nop Sep 10, 2021
@codecov
Copy link
codecov bot commented Sep 10, 2021 •
edited
Loading

Codecov Report

Merging #3385 (f96c12f) into master (43215cd) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3385      +/-   ##
==========================================
+ Coverage   90.22%   90.27%   +0.05%     
==========================================
  Files         152      152              
  Lines       10844    10852       +8     
==========================================
+ Hits         9784     9797      +13     
+ Misses       1060     1055       -5
Flag Coverage Δ
daemon 45.46% <0.00%> (-0.07%) ⬇️
jina 90.26% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/neural_ops.py 88.99% <100.00%> (+0.20%) ⬆️
jina/hubble/hubio.py 88.81% <0.00%> (ø)
jina/jaml/__init__.py 95.39% <0.00%> (ø)
jina/flow/base.py 89.08% <0.00%> (+0.04%) ⬆️
jina/types/arrays/document.py 88.06% <0.00%> (+0.09%) ⬆️
jina/peapods/peas/__init__.py 85.98% <0.00%> (+0.18%) ⬆️
jina/types/arrays/memmap.py 94.98% <0.00%> (+0.35%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 93.33% <0.00%> (+1.90%) ⬆️
jina/clients/base/websocket.py 90.90% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c05ab7...f96c12f. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1311, delta to last 2 avg.: +21%
  • 🐎🐎🐎🐎 query QPS at 55, delta to last 2 avg.: +25%
  • 🐎🐎🐎🐎 dam extend QPS at 50985, delta to last 2 avg.: +27%
  • 🐎🐎🐎🐎 avg flow time within 1.6993 seconds, delta to last 2 avg.: -3%
  • 🐢🐢 import jina within 0.4049 seconds, delta to last 2 avg.: -9%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1311 55 50985 1.6993 0.4049
2.0.23 1136 46 41423 1.763 0.4527
2.0.22 1021 41 38702 1.7526 0.4446

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 3e8c35e into master Sep 10, 2021
@hanxiao hanxiao deleted the fix-match-none branch September 10, 2021 16:09
deepankarm pushed a commit that referenced this pull request Sep 14, 2021
@hanxiao @deepankarm
fix: empty DA match should be just nop (#3385)
0072f91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM Awaiting requested review from JoanFM

@slettner slettner Awaiting requested review from slettner

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanxiao
0