8000 fix(types): allow da extend with None by jacobowitz · Pull Request #3379 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(types): allow da extend with None #3379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2021
Merged

fix(types): allow da extend with None #3379

merged 1 commit into from
Sep 10, 2021

Conversation

jacobowitz
Copy link
Contributor

Dont fail if DocumentArray.extend() is called with None. Just do nothing.

@jacobowitz jacobowitz requested a review from a team as a code owner September 10, 2021 06:34
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Sep 10, 2021
@codecov
Copy link
codecov bot commented Sep 10, 2021 •
edited
Loading

Codecov Report

Merging #3379 (7fb009f) into master (71ef971) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3379      +/-   ##
==========================================
+ Coverage   90.19%   90.23%   +0.03%     
==========================================
  Files         152      152              
  Lines       10844    10846       +2     
==========================================
+ Hits         9781     9787       +6     
+ Misses       1063     1059       -4
Flag Coverage Δ
daemon 45.47% <0.00%> (-0.03%) ⬇️
jina 90.22% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/document.py 88.06% <100.00%> (+0.09%) ⬆️
jina/types/arrays/memmap.py 94.98% <0.00%> (+0.35%) ⬆️
jina/helper.py 83.33% <0.00%> (+0.36%) ⬆️
jina/enums.py 96.06% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61caee5...7fb009f. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1149, delta to last 2 avg.: -4%
  • 😶 query QPS at 46, delta to last 2 avg.: -5%
  • 😶 dam extend QPS at 41293, delta to last 2 avg.: -17%
  • 😶 avg flow time within 1.2539 seconds, delta to last 2 avg.: -23%
  • 🐎🐎🐎🐎 import jina within 0.4897 seconds, delta to last 2 avg.: +27%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1149 46 41293 1.2539 0.4897
2.0.23 1352 56 60470 1.4529 0.3425
2.0.22 1045 40 39174 1.8053 0.424

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit b0e46a3 into master Sep 10, 2021
@hanxiao hanxiao deleted the fix-da-extend-none branch September 10, 2021 07:07
deepankarm pushed a commit that referenced this pull request Sep 14, 2021
@jacobowitz @deepankarm
fix(types): allow da extend with None (#3379)
58d7da0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@numb3r3 numb3r3 Awaiting requested review from numb3r3

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobowitz @hanxiao
0