8000 fix: Remove unused class MyConverter by gaocegege · Pull Request #3374 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Remove unused class MyConverter #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2021
Merged

fix: Remove unused class MyConverter #3374

merged 1 commit into from
Sep 13, 2021

Conversation

gaocegege
Copy link
Contributor

We already implement the conversion logic in MyEncoder. Thus there is no need to import it.

BTW, should we remove the definition of MyConverter from my_executors.py?

@gaocegege gaocegege requested a review from a team as a code owner September 9, 2021 09:43
alanthssss
alanthssss previously approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor
@alanthssss alanthssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😁

@gaocegege
fix: remove unused class
a826efb 
Signed-off-by: cegao <cegao@tencent.com>
@gaocegege
Copy link
Contributor Author

commit message is not valid, I am re-pushing to fix it.

@codecov
Copy link
8000 codecov bot commented Sep 10, 2021 •
edited
Loading

Codecov Report

Merging #3374 (a826efb) into master (d78ff67) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3374      +/-   ##
==========================================
- Coverage   90.23%   90.21%   -0.02%     
==========================================
  Files         152      152              
  Lines       10842    10846       +4     
==========================================
+ Hits         9783     9785       +2     
- Misses       1059     1061       +2
Flag Coverage Δ
daemon 45.47% <0.00%> (-0.02%) ⬇️
jina 90.20% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helloworld/fashion/app.py 82.60% <50.00%> (ø)
jina/peapods/runtimes/jinad/__init__.py 91.42% <0.00%> (-1.91%) ⬇️
jina/helper.py 82.97% <0.00%> (-0.37%) ⬇️
jina/hubble/hubio.py 88.81% <0.00%> (ø)
jina/types/arrays/document.py 88.06% <0.00%> (+0.09%) ⬆️
jina/types/arrays/memmap.py 94.98% <0.00%> (+0.35%) ⬆️
jina/peapods/pods/k8s.py 91.86% <0.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78ff67...a826efb. Read the comment docs.

@hanxiao hanxiao merged commit 9c98f60 into jina-ai:master Sep 13, 2021
deepankarm pushed a commit that referenced this pull request Sep 14, 2021
@gaocegege @deepankarm
fix: remove unused class (#3374)
8907b61 
Signed-off-by: cegao <cegao@tencent.com>
@gaocegege gaocegege deleted the unused branch September 16, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanthssss alanthssss alanthssss left review comments

@nan-wang nan-wang Awaiting requested review from nan-wang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaocegege @alanthssss @hanxiao
0