fix(routing): fix static routing table args #3363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
a4d4d94 to
1693857
Compare
Codecov Report
@@ Coverage Diff @@
## master #3363 +/- ##
==========================================
+ Coverage 83.53% 89.61% +6.08%
==========================================
Files 152 152
Lines 10840 10842 +2
==========================================
+ Hits 9055 9716 +661
+ Misses 1785 1126 -659
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
29526a3 to
dd6cfb8
Compare
florian-hoenicke
approved these changes
Sep 9, 2021
deepankarm
pushed a commit
that referenced
this pull request
Sep 14, 2021
* fix(routing): fix static routing table args * fix(routing): move routing table args outside of gateway * style: fix overload and cli autocomplete * style: fix overload and cli autocomplete * fix(routing): fix zmqlet static routing check * fix(routing): fix args setting Co-authored-by: Jina Dev Bot <dev-bot@jina.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to use static routing tables in kubernetes (meaning not sending it in every message), I noticed that this actually does not work when using the real CLI.
I was using the wrong pattern before (--flag ), this PR fixes this and unifies the arg to
--static-routing-table.By default this args is false and only if provided it disables sending out the routing table.
Also I fix I minor thing in the K8s pod where I need to regenerate the args on demand (because some args are calculated later).