fix: #3351 #3353
fix: #3351 #3353
Conversation
|
This PR closes: #3351 |
Codecov Report
@@ Coverage Diff @@
## master #3353 +/- ##
==========================================
+ Coverage 88.72% 89.70% +0.97%
==========================================
Files 152 152
Lines 10806 10843 +37
==========================================
+ Hits 9588 9727 +139
+ Misses 1218 1116 -102
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
jina/jaml/parsers/executor/legacy.py
Outdated
| except Exception as e: | ||
| print(f'========= {e}') |
There was a problem hiding this comment.
| except Exception as e: | |
| print(f'========= {e}') | |
| except Exception: | |
| pass # intentionally pass as <write why there is no reason to handle it> |
df6264f to
3becf72
Compare
jina/jaml/parsers/executor/legacy.py
Outdated
| """Based on name, compute if this is a tail/head Pea or a main Pea | ||
|
|
||
| :param data: the data for the parser | ||
| :return: boolean of whether it is tail/head or main |
There was a problem hiding this comment.
that description is slightly misleading? I assume this is True if it is head/tail .
So I'd write :return: boolean True if it is tail/head., False otherwise
There was a problem hiding this comment.
adjusted, thanks
jina/jaml/parsers/executor/legacy.py
Outdated
| @@ -78,7 +78,8 @@ def parse(self, cls: Type['BaseExecutor'], data: Dict) -> 'BaseExecutor': | |||
| arguments_from_cls = LegacyParser._get_all_arguments(cls) | |||
| arguments_from_yaml = set(data.get('with', {})) | |||
| difference_set = arguments_from_yaml - arguments_from_cls | |||
| if any(difference_set): | |||
| # only log warnings about unknown args for main Pea | |||
| if any(difference_set) and LegacyParser.is_tail_or_head(data): | |||
There was a problem hiding this comment.
I somehow dont get this one? Your comment says you only want to do this for a main pea but then you enter the if here if it is tail/head? I guess I am missing something here?
There was a problem hiding this comment.
I fixed that. Initially I wanted the method to return if it's a main Pea. But switched it around and forgot to change here. The pains of not having a proper test for logging
3becf72 to
426d259
Compare
426d259 to
20f28d0
Compare
No description provided.