8000 feat: k8s parallel for shards by florian-hoenicke · Pull Request #3350 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: k8s parallel for shards #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2021
Merged

feat: k8s parallel for shards #3350

merged 2 commits into from
Sep 6, 2021

Conversation

florian-hoenicke
Copy link
Member

Useful information for shards to know which virtual shard to pick.

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Sep 6, 2021
@codecov
Copy link
codecov bot commented Sep 6, 2021 •
edited
Loading

Codecov Report

Merging #3350 (87e2d4e) into master (9a8c431) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3350      +/-   ##
==========================================
- Coverage   89.68%   89.64%   -0.05%     
==========================================
  Files         152      152              
  Lines       10823    10823              
==========================================
- Hits         9707     9702       -5     
- Misses       1116     1121       +5
Flag Coverage Δ
daemon 45.60% <ø> (ø)
jina 89.63% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/pods/k8slib/kubernetes_deployment.py 91.22% <ø> (ø)
jina/clients/base/grpc.py 63.82% <0.00%> (-6.39%) ⬇️
jina/peapods/runtimes/gateway/prefetch.py 93.82% <0.00%> (-1.24%) ⬇️
jina/helper.py 82.97% <0.00%> (-0.37%) ⬇️
jina/enums.py 96.06% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8c431...87e2d4e. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Sep 6, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐎🐎 index QPS at 1181, delta to last 2 avg.: +6%
  • 😶 query QPS at 47, delta to last 2 avg.: +2%
  • 😶 dam extend QPS at 48894, delta to last 2 avg.: +6%
  • 😶 avg flow time within 1.731 seconds, delta to last 2 avg.: +5%
  • 😶 import jina within 0.3976 seconds, delta to last 2 avg.: -2%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1181 47 48894 1.731 0.3976
2.0.23 1142 48 49858 1.5096 0.4072
2.0.22 1083 43 41782 1.7568 0.4092

Backed by latency-tracking. Further commits will update this comment.

@florian-hoenicke florian-hoenicke marked this pull request as ready for review September 6, 2021 13:53
@florian-hoenicke florian-hoenicke requested a review from a team as a code owner September 6, 2021 13:53
@florian-hoenicke florian-hoenicke requested review from winstonww, BastinJafari and cristianmtr and removed request for winstonww and BastinJafari September 6, 2021 13:53
@florian-hoenicke florian-hoenicke merged commit cbe578d into master Sep 6, 2021
@florian-hoenicke florian-hoenicke deleted the feat-k8s-parallel-for-shards branch September 6, 2021 14:01
deepankarm pushed a commit that referenced this pull request Sep 14, 2021
@florian-hoenicke @deepankarm
feat: k8s parallel for shards (#3350)
ec7894b 
* feat: k8s parallel for shards

* feat: k8s shards parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianmtr cristianmtr cristianmtr approved these changes

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-hoenicke @cristianmtr
0