8000 fix(daemon): port mapping for compound pods by deepankarm · Pull Request #3304 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(daemon): port mapping for compound pods #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 31, 2021
Merged

fix(daemon): port mapping for compound pods #3304

merged 4 commits into from
Aug 31, 2021

Conversation

deepankarm
Copy link
Contributor
@deepankarm deepankarm commented Aug 31, 2021 •
edited
Loading

This addresses issues with port-mapping, when inside a remote Flow, we start a CompoundPod which uses ContainerRuntime. So the head & tail Peas live inside the Flow container & they need to be set/exposed correctly inside main-daemon & partial-daemon. With this PR, we have introduced PortMappings which take a json of pod_name, pea_name & corresponding Ports.

@deepankarm deepankarm requested a review from a team as a code owner August 31, 2021 08:11
@deepankarm deepankarm requested review from mapleeit and JoanFM August 31, 2021 08:11
@deepankarm deepankarm changed the title fix: daemon port mapping for compound pods fix(daemon): port mapping for compound pods Aug 31, 2021
@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/daemon area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod area/cli This issue/PR affects the command line interface labels Aug 31, 2021
@deepankarm deepankarm force-pushed the fix-daemon-port-mapping branch from 3e12f73 to 86b02ec Compare August 31, 2021 08:15
@codecov
Copy link
codecov bot commented Aug 31, 2021 •
edited
Loading

Codecov Report

Merging #3304 (1de1e5e) into master (b8a61b6) will increase coverage by 1.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3304      +/-   ##
==========================================
+ Coverage   88.72%   89.81%   +1.08%     
==========================================
  Files         152      152      
8000
        
  Lines       10806    10806              
==========================================
+ Hits         9588     9705     +117     
+ Misses       1218     1101     -117
Flag Coverage Δ
daemon 45.65% <ø> (ø)
jina 89.80% <ø> (+1.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/zmq/__init__.py 89.04% <0.00%> (+0.69%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 91.42% <0.00%> (+0.95%) ⬆️
jina/peapods/runtimes/gateway/prefetch.py 95.06% <0.00%> (+1.23%) ⬆️
jina/peapods/runtimes/gateway/http/app.py 92.40% <0.00%> (+1.26%) ⬆️
jina/peapods/pods/compound.py 91.72% <0.00%> (+1.37%) ⬆️
jina/types/message/__init__.py 87.37% <0.00%> (+1.45%) ⬆️
jina/peapods/runtimes/zmq/zed.py 94.38% <0.00%> (+1.53%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
jina/peapods/runtimes/zmq/asyncio.py 96.36% <0.00%> (+1.81%) ⬆️
jina/jaml/helper.py 85.36% <0.00%> (+2.43%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc72fd...1de1e5e. Read the comment docs.

@github-actions github-actions bot removed area/cli This issue/PR affects the command line interface component/peapod area/network This issue/PR affects network functionality area/core This issue/PR affects the core codebase labels Aug 31, 2021
@github-actions
Copy link
github-actions bot commented Aug 31, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1378, delta to last 2 avg.: +15%
  • 🐎🐎🐎🐎 query QPS at 58, delta to last 2 avg.: +19%
  • 🐎🐎🐎🐎 dam extend QPS at 61215, delta to last 2 avg.: +23%
  • 🐎🐎🐎🐎 avg flow time within 1.122 seconds, delta to last 2 avg.: -17%
  • 🐢🐢 import jina within 0.3431 seconds, delta to last 2 avg.: -14%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1378 58 61215 1.122 0.3431
2.0.21 965 38 36501 1.5955 0.4714
2.0.20 1417 58 62783 1.1205 0.3327

Backed by latency-tracking. Further commits will update this comment.

@deepankarm deepankarm force-pushed the fix-daemon-port-mapping branch from 540197c to 1de1e5e Compare August 31, 2021 10:08
@deepankarm deepankarm requested a review from jacobowitz August 31, 2021 10:11
jacobowitz
jacobowitz approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor
@jacobowitz jacobowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant follow in every detail, but generally looks like a good solution for compound pods to me 👍

@deepankarm deepankarm merged commit 4221b25 into master Aug 31, 2021
@deepankarm deepankarm deleted the fix-daemon-port-mapping branch August 31, 2021 11:10
@deepankarm deepankarm restored the fix-daemon-port-mapping branch August 31, 2021 14:48
@JoanFM JoanFM deleted the fix-daemon-port-mapping branch November 13, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobowitz jacobowitz jacobowitz approved these changes

@mapleeit mapleeit Awaiting requested review from mapleeit

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/daemon area/testing This issue/PR affects testing size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepankarm @jacobowitz
0